Thread: Incorrect comment in heapam.c
Line 834 of heapam.c has the following comment: /* * This is formatted so oddly so that the correspondence to the macro * definition in access/heapam.h is maintained. */ In fact, that macro is defined in access/htup.h...should it be? --=20 Peter Geoghegan =A0 =A0 =A0 http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services
On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter@2ndquadrant.com> wr= ote: > Line 834 of heapam.c has the following comment: > > /* > =A0* This is formatted so oddly so that the correspondence to the macro > =A0* definition in access/heapam.h is maintained. > =A0*/ > > In fact, that macro is defined in access/htup.h...should it be? IMHO comment is wrong, code is in the right place. --=20 =A0Simon Riggs=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 http:/= /www.2ndQuadrant.com/ =A0PostgreSQL Development, 24x7 Support, Training & Services
Simon Riggs <simon@2ndQuadrant.com> writes:
> On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter@2ndquadrant.com> wrote:
>> In fact, that macro is defined in access/htup.h...should it be?
> IMHO comment is wrong, code is in the right place.
It used to be in heapam.h ... evidently, whoever moved it missed this
comment.
regards, tom lane
On 20 December 2011 18:11, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Simon Riggs <simon@2ndQuadrant.com> writes: >> On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter@2ndquadrant.com>= wrote: >>> In fact, that macro is defined in access/htup.h...should it be? > >> IMHO comment is wrong, code is in the right place. > > It used to be in heapam.h ... evidently, whoever moved it missed this > comment. I imagined that that was the case. It's a fairly inconsequential bug, but it is worth fixing... --=20 Peter Geoghegan =A0 =A0 =A0 http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services
On Wed, Dec 21, 2011 at 6:21 AM, Peter Geoghegan <peter@2ndquadrant.com> wrote: > On 20 December 2011 18:11, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Simon Riggs <simon@2ndQuadrant.com> writes: >>> On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter@2ndquadrant.com> wrote: >>>> In fact, that macro is defined in access/htup.h...should it be? >> >>> IMHO comment is wrong, code is in the right place. >> >> It used to be in heapam.h ... evidently, whoever moved it missed this >> comment. > > I imagined that that was the case. > > It's a fairly inconsequential bug, but it is worth fixing... Fixed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 17 January 2012 01:37, Robert Haas <robertmhaas@gmail.com> wrote: >> It's a fairly inconsequential bug, but it is worth fixing... > > Fixed. Thanks. --=20 Peter Geoghegan =A0 =A0 =A0 http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services