Thread: BUG #2015: typo in sql_help

BUG #2015: typo in sql_help

From
"HOTTA Michihide"
Date:
The following bug has been logged online:

Bug reference:      2015
Logged by:          HOTTA Michihide
Email address:      hotta@net-newbie.com
PostgreSQL version: 8.1RC1
Operating system:   Vine Linux 3.2
Description:        typo in sql_help
Details:

sorry not to have checked cvs version.



--- sql_help.h.orig     2005-10-30 14:24:25.000000000 +0900
+++ sql_help.h  2005-11-02 14:54:20.000000000 +0900
@@ -94,7 +94,7 @@
       N_("ALTER TYPE name OWNER TO new_owner \nALTER TYPE name SET SCHEMA
new_schema") },

     { "ALTER USER",
-      N_("change a database role"),
+      N_("change a database user account"),
       N_("ALTER USER name [ [ WITH ] option [ ... ] ]\n\nwhere option can
be:\n    \n      SUPERUSER | NOSUPERUSER\n    | CREATEDB | NOCREATEDB\n    |
CREATEROLE | NOCREATEROLE\n    | CREATEUSER | NOCREATEUSER\n    | INHERIT |
NOINHERIT\n    | LOGIN | NOLOGIN\n    | CONNECTION LIMIT connlimit\n    | [
ENCRYPTED | UNENCRYPTED ] PASSWORD 'password'\n    | VALID UNTIL 'timestamp'
\n\nALTER USER name RENAME TO newname\n\nALTER USER name SET parameter { TO
| = } { value | DEFAULT }\nALTER USER name RESET parameter") },

     { "ANALYZE",
@@ -162,7 +162,7 @@
       N_("CREATE [ OR REPLACE ] FUNCTION\n    name ( [ [ argmode ] [
argname ] argtype [, ...] ] )\n    [ RETURNS rettype ]\n  { LANGUAGE
langname\n    | IMMUTABLE | STABLE | VOLATILE\n    | CALLED ON NULL INPUT |
RETURNS NULL ON NULL INPUT | STRICT\n    | [ EXTERNAL ] SECURITY INVOKER | [
EXTERNAL ] SECURITY DEFINER\n    | AS 'definition'\n    | AS 'obj_file',
'link_symbol'\n  } ...\n    [ WITH ( attribute [, ...] ) ]") },

     { "CREATE GROUP",
-      N_("define a new database role"),
+      N_("define a new user group"),
       N_("CREATE GROUP name [ [ WITH ] option [ ... ] ]\n\nwhere option can
be:\n    \n      SUPERUSER | NOSUPERUSER\n    | CREATEDB | NOCREATEDB\n    |
CREATEROLE | NOCREATEROLE\n    | CREATEUSER | NOCREATEUSER\n    | INHERIT |
NOINHERIT\n    | LOGIN | NOLOGIN\n    | [ ENCRYPTED | UNENCRYPTED ] PASSWORD
'password'\n    | VALID UNTIL 'timestamp' \n    | IN ROLE rolename [, ...]\n
   | IN GROUP rolename [, ...]\n    | ROLE rolename [, ...]\n    | ADMIN
rolename [, ...]\n    | USER rolename [, ...]\n    | SYSID uid") },

     { "CREATE INDEX",
@@ -218,7 +218,7 @@
       N_("CREATE TYPE name AS\n    ( attribute_name data_type [, ... ]
)\n\nCREATE TYPE name (\n    INPUT = input_function,\n    OUTPUT =
output_function\n    [ , RECEIVE = receive_function ]\n    [ , SEND =
send_function ]\n    [ , ANALYZE = analyze_function ]\n    [ ,
INTERNALLENGTH = { internallength | VARIABLE } ]\n    [ , PASSEDBYVALUE ]\n
  [ , ALIGNMENT = alignment ]\n    [ , STORAGE = storage ]\n    [ , DEFAULT
= default ]\n    [ , ELEMENT = element ]\n    [ , DELIMITER = delimiter
]\n)") },

     { "CREATE USER",
-      N_("define a new database role"),
+      N_("define a new database user account"),
       N_("CREATE USER name [ [ WITH ] option [ ... ] ]\n\nwhere option can
be:\n    \n      SUPERUSER | NOSUPERUSER\n    | CREATEDB | NOCREATEDB\n    |
CREATEROLE | NOCREATEROLE\n    | CREATEUSER | NOCREATEUSER\n    | INHERIT |
NOINHERIT\n    | LOGIN | NOLOGIN\n    | CONNECTION LIMIT connlimit\n    | [
ENCRYPTED | UNENCRYPTED ] PASSWORD 'password'\n    | VALID UNTIL 'timestamp'
\n    | IN ROLE rolename [, ...]\n    | IN GROUP rolename [, ...]\n    |
ROLE rolename [, ...]\n    | ADMIN rolename [, ...]\n    | USER rolename [,
...]\n    | SYSID uid") },

     { "CREATE VIEW",
@@ -262,7 +262,7 @@
       N_("DROP FUNCTION name ( [ [ argmode ] [ argname ] argtype [, ...] ]
)\n    [ CASCADE | RESTRICT ]") },

     { "DROP GROUP",
-      N_("remove a database role"),
+      N_("remove a user group"),
       N_("DROP GROUP name [, ...]") },

     { "DROP INDEX",
@@ -314,7 +314,7 @@
       N_("DROP TYPE name [, ...] [ CASCADE | RESTRICT ]") },

     { "DROP USER",
-      N_("remove a database role"),
+      N_("remove a database user account"),
       N_("DROP USER name [, ...]") },

     { "DROP VIEW",

Re: BUG #2015: typo in sql_help

From
Peter Eisentraut
Date:
HOTTA Michihide wrote:
> -      N_("change a database role"),
> +      N_("change a database user account"),
[etc]

The current code is correct.  User accounts and groups are now mapped to
database roles.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

Re: BUG #2015: typo in sql_help

From
Tom Lane
Date:
"HOTTA Michihide" <hotta@net-newbie.com> writes:
> sorry not to have checked cvs version.

It isn't in CVS, it's a generated file, so this patch is pretty
meaningless.  Why do you think these changes are appropriate?
They look to me like attempts to revert intentional 8.1 documentation
changes having to do with the new role feature.  Please look at the sgml
reference pages (which is what sql_help is generated from) and see if
you still think the command descriptions should be changed back.

            regards, tom lane