Thread: jdbc2 bug in absolute (ResultSet.java)
The "absolute" method is called by the relative method to change the cursor position. However, I noticed that absolute does not change current_row, it only loads the data. Shoudn't absolute contain the following line : current_row=index; ---------------------------------------------------------------- Travis Bauer | CS Grad Student | IU |www.cs.indiana.edu/~trbauer ----------------------------------------------------------------
You also need to remove the condition causing the procedure to return falsi if index==0. I've changed it in my code, and it fixed a few bugs that were cropping up. ---------------------------------------------------------------- Travis Bauer | CS Grad Student | IU |www.cs.indiana.edu/~trbauer ---------------------------------------------------------------- On Thu, 25 May 2000, Travis Bauer wrote: > The "absolute" method is called by the relative method to change the > cursor position. However, I noticed that absolute does not change > current_row, it only loads the data. > > Shoudn't absolute contain the following line : > > current_row=index; > > ---------------------------------------------------------------- > Travis Bauer | CS Grad Student | IU |www.cs.indiana.edu/~trbauer > ---------------------------------------------------------------- > >
> The "absolute" method is called by the relative method to change the
> cursor position. However, I noticed that absolute does not change
> current_row, it only loads the data.
>
> Shoudn't absolute contain the following line :
>
> current_row=index;
>
The current code shows:
current_row=internalIndex;
Seems it has been fixed by someone. Yes, I see now that the 7.0.0
version has this missing.
Not sure how to handle this. The fix will be in 7.1. Just not sure if
I should back-patch this into 7.0.X because there are other fixes in
those java patches I don't understand.
--
Bruce Momjian | http://www.op.net/~candle
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
I'm the one who posted this question and also posted the patch to fix it. Thanks for including it. The version of the JDBC driver in the cvs fixes all the problems I know of regarding indexing (I re-wrote absolute). Absolute and relative do not work properly in the 7.0 driver. Thanks, ---------------------------------------------------------------- Travis Bauer | CS Grad Student | IU |www.cs.indiana.edu/~trbauer ---------------------------------------------------------------- On Tue, 13 Jun 2000, Bruce Momjian wrote: > > The "absolute" method is called by the relative method to change the > > cursor position. However, I noticed that absolute does not change > > current_row, it only loads the data. > > > > Shoudn't absolute contain the following line : > > > > current_row=index; > > > > The current code shows: > > current_row=internalIndex; > > Seems it has been fixed by someone. Yes, I see now that the 7.0.0 > version has this missing. > > Not sure how to handle this. The fix will be in 7.1. Just not sure if > I should back-patch this into 7.0.X because there are other fixes in > those java patches I don't understand. > > -- > Bruce Momjian | http://www.op.net/~candle > pgman@candle.pha.pa.us | (610) 853-3000 > + If your life is a hard drive, | 830 Blythe Avenue > + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 >
Thanks. I will back-patch these in to 7.0.X. > I'm the one who posted this question and also posted the patch to fix it. > Thanks for including it. The version of the JDBC driver in the cvs fixes > all the problems I know of regarding indexing (I re-wrote > absolute). Absolute and relative do not work properly in the 7.0 driver. > > Thanks, > > ---------------------------------------------------------------- > Travis Bauer | CS Grad Student | IU |www.cs.indiana.edu/~trbauer > ---------------------------------------------------------------- > > On Tue, 13 Jun 2000, Bruce Momjian wrote: > > > > The "absolute" method is called by the relative method to change the > > > cursor position. However, I noticed that absolute does not change > > > current_row, it only loads the data. > > > > > > Shoudn't absolute contain the following line : > > > > > > current_row=index; > > > > > > > The current code shows: > > > > current_row=internalIndex; > > > > Seems it has been fixed by someone. Yes, I see now that the 7.0.0 > > version has this missing. > > > > Not sure how to handle this. The fix will be in 7.1. Just not sure if > > I should back-patch this into 7.0.X because there are other fixes in > > those java patches I don't understand. > > > > -- > > Bruce Momjian | http://www.op.net/~candle > > pgman@candle.pha.pa.us | (610) 853-3000 > > + If your life is a hard drive, | 830 Blythe Avenue > > + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 > > > > -- Bruce Momjian | http://www.op.net/~candle pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026