Thread: Bug: Little mistake in comment in inheriting table

Bug: Little mistake in comment in inheriting table

From
Vojtěch Látal
Date:
Hi,
just a little thing: I wanted to try inheriting. So I made a table
"del" which inherits from table "vehicles".

Create script follows:
-- Table: del

-- DROP TABLE del;

CREATE TABLE del
(
-- Inherited from table del:  id integer NOT NULL DEFAULT
nextval('vehicle_id_seq'::regclass),
-- Inherited from table del:  vin character varying(20) NOT NULL,
-- Inherited from table del:  licence_plate character varying(12) NOT NULL,a boolean
)
INHERITS (vehicles)
WITH (OIDS=FALSE
);
ALTER TABLE del OWNER TO gary;


It seems it should be "-- Inherited from table vehicles:" instead of
current "-- Inherited from table del:".

Version: 1.12.1 from Community repo
OS: ArchLinux, kernel 2.6.35
PostgreSQL: 9.0.1

Steps to reproduce:
1) (create database,) create table, put some columns into.
2) create another table from contextual menu, select "New Table..."
3) "New Table..." dialog opens, put some table name in, open "Inherits" tab
4) select table you created in 1), click Add
5) select "Columns" tab, add some column
6) create table by clicking "OK"
7) select newly created table from step 6) and in SQL pane you'll see
what I've included.

Thanks guys for huge piece of good work. I really appreciate what you are doing.


Regards
Vojtěch Látal


Re: Bug: Little mistake in comment in inheriting table

From
Guillaume Lelarge
Date:
Le 11/11/2010 19:53, Vojtěch Látal a écrit :
> Hi,
> just a little thing: I wanted to try inheriting. So I made a table
> "del" which inherits from table "vehicles".
> 
> Create script follows:
> -- Table: del
> 
> -- DROP TABLE del;
> 
> CREATE TABLE del
> (
> -- Inherited from table del:  id integer NOT NULL DEFAULT
> nextval('vehicle_id_seq'::regclass),
> -- Inherited from table del:  vin character varying(20) NOT NULL,
> -- Inherited from table del:  licence_plate character varying(12) NOT NULL,
>  a boolean
> )
> INHERITS (vehicles)
> WITH (
>  OIDS=FALSE
> );
> ALTER TABLE del OWNER TO gary;
> 
> 
> It seems it should be "-- Inherited from table vehicles:" instead of
> current "-- Inherited from table del:".
> 

You're right. I pushed a fix for this. It fixes your specific issue.
Unfortunately, there is still an issue for table heriting columns from
more than one table. I'll work on that ASAP.


-- 
Guillaumehttp://www.postgresql.frhttp://dalibo.com