Thread: bug restore window

Version 1.4.0
When you restore a database and there are no problems the Ok button
turns into a Done button. Clicking on this closes the window.
When there are errors or warnings, the OK button stays an ok button
and clicking on it attempts to do the restore again.
To get out of the window you must click cancel.

I would think the button to get out should always get you out. There
is never (as far as I can think of) a time when you would want to run
the restore a second time. Even if there were errors and something has
to be changed, you would want to go out of that window first to fix
the problem.

Thank You
Sim

Sim Zacks wrote:
> Version 1.4.0
> When you restore a database and there are no problems the Ok button
> turns into a Done button. Clicking on this closes the window.
> When there are errors or warnings, the OK button stays an ok button
> and clicking on it attempts to do the restore again.
> To get out of the window you must click cancel.
> 
> I would think the button to get out should always get you out. There
> is never (as far as I can think of) a time when you would want to run
> the restore a second time.

The behaviour is intentional; if the restore failed, you might want to 
correct your parameters and try again.
To leave the dialog (any dialog), you always can use Cancel or the close 
button. The OK button turns to Done to prevent you from rerunning the 
successful restore again.

Regards,
Andreas

The problem is that on a successful restore with warnings, the user is
used to clicking the Done button. I have had to drop the database and
restore again a number of times because I was used to clicking the
button and it tried to restore again.
If it completely fails, then I see your point.

Sim
________________________________________________________________________________

Sim Zacks wrote:
> Version 1.4.0
> When you restore a database and there are no problems the Ok button
> turns into a Done button. Clicking on this closes the window.
> When there are errors or warnings, the OK button stays an ok button
> and clicking on it attempts to do the restore again.
> To get out of the window you must click cancel.
> 
> I would think the button to get out should always get you out. There
> is never (as far as I can think of) a time when you would want to run
> the restore a second time.

The behaviour is intentional; if the restore failed, you might want to 
correct your parameters and try again.
To leave the dialog (any dialog), you always can use Cancel or the close 
button. The OK button turns to Done to prevent you from rerunning the 
successful restore again.

Regards,
Andreas

Sim Zacks wrote:
> The problem is that on a successful restore with warnings, the user is
> used to clicking the Done button. I have had to drop the database and
> restore again a number of times because I was used to clicking the
> button and it tried to restore again.
> If it completely fails, then I see your point.

OK, I understand now, it's the warning case. Seems the pg_restore return 
code handling needs some tuning.

Regards,
Andreas