Thread: PgAdmin III: Two bugs
PgAdmin III version: 1.0.0 First bug: Creating UNIQUE constraint executes ALTER TABLE ... ADD CONSTRAINT asfd PRIMARY KEY .... Second bug: This bug has already been reported, but until now I haven't been able to consistently reproduce it... Well, there is scenario that causes this bug to show up: 1) add new connection to server and enter any database as initial database, 2) connect using this connection, 3) drop database that was entered as an initial database. PgAdmin III shows message that this database cannot be dropped and crashes. Regards, Matej Rizman
Hi Matej > -----Original Message----- > From: Matej Rizman [mailto:matej.rizman@guest.arnes.si] > Sent: 05 October 2003 23:37 > To: pgadmin-support@postgresql.org > Subject: [pgadmin-support] PgAdmin III: Two bugs > > > > PgAdmin III version: 1.0.0 > > First bug: > Creating UNIQUE constraint executes ALTER TABLE ... ADD > CONSTRAINT asfd PRIMARY KEY .... I cannot reproduce that - what steps did you take? > Second bug: > This bug has already been reported, but until now I haven't > been able to consistently reproduce it... Well, there is > scenario that causes this bug to show up: > 1) add new connection to server and enter any database as > initial database, > 2) connect using this connection, > 3) drop database that was entered as an initial database. > > PgAdmin III shows message that this database cannot be > dropped and crashes. I fixed that one last week :-) Regards, Dave,
> -----Original Message----- > From: Dave Page > Sent: 06 October 2003 10:17 > To: Matej Rizman; pgadmin-support@postgresql.org > Subject: Re: [pgadmin-support] PgAdmin III: Two bugs > > > Hi Matej > > > -----Original Message----- > > From: Matej Rizman [mailto:matej.rizman@guest.arnes.si] > > Sent: 05 October 2003 23:37 > > To: pgadmin-support@postgresql.org > > Subject: [pgadmin-support] PgAdmin III: Two bugs > > > > > > > > PgAdmin III version: 1.0.0 > > > > First bug: > > Creating UNIQUE constraint executes ALTER TABLE ... ADD > > CONSTRAINT asfd PRIMARY KEY .... > > I cannot reproduce that - what steps did you take? Scrub that, I see it. If you right click and then create New Unique Constraint then you get a primary key, however if you do it from the table properties dialgoue (as I do) it works fine apart from another bugette in which the anem is doubled (ie frog becomes frogfrog). Andreas; can you take a look at this please? I've spent a while on it but haven't figured it out and need to get on with some paid work (and you'll no doubt fix it in a few minutes :-))... Cheers, Dave.
Dave Page wrote: > > >>-----Original Message----- >>From: Dave Page >>Sent: 06 October 2003 10:17 >>To: Matej Rizman; pgadmin-support@postgresql.org >>Subject: Re: [pgadmin-support] PgAdmin III: Two bugs >> >> >>Hi Matej >> >> >> >>>-----Original Message----- >>>From: Matej Rizman [mailto:matej.rizman@guest.arnes.si] >>>Sent: 05 October 2003 23:37 >>>To: pgadmin-support@postgresql.org >>>Subject: [pgadmin-support] PgAdmin III: Two bugs >>> >>> >>> >>>PgAdmin III version: 1.0.0 >>> >>>First bug: >>>Creating UNIQUE constraint executes ALTER TABLE ... ADD >>>CONSTRAINT asfd PRIMARY KEY .... >>> >>> >>I cannot reproduce that - what steps did you take? >> >> > >Scrub that, I see it. If you right click and then create New Unique >Constraint then you get a primary key, however if you do it from the >table properties dialgoue (as I do) it works fine apart from another >bugette in which the anem is doubled (ie frog becomes frogfrog). > >Andreas; can you take a look at this please? I've spent a while on it >but haven't figured it out and need to get on with some paid work (and >you'll no doubt fix it in a few minutes :-))... > Fixed in head and branch. dlgIndexConstraint::GetSql() was hard-coded to "PRIMARY KEY" instead of wxString(typeList[objectType].typeName).Upper(). Regards, Andreas
> -----Original Message----- > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > Sent: 06 October 2003 16:48 > To: Dave Page > Cc: Matej Rizman; pgadmin-support@postgresql.org > Subject: Re: [pgadmin-support] PgAdmin III: Two bugs > > > > > >Scrub that, I see it. If you right click and then create New Unique > >Constraint then you get a primary key, however if you do it from the > >table properties dialgoue (as I do) it works fine apart from another > >bugette in which the anem is doubled (ie frog becomes frogfrog). > > > >Andreas; can you take a look at this please? I've spent a > while on it > >but haven't figured it out and need to get on with some paid > work (and > >you'll no doubt fix it in a few minutes :-))... > > > Fixed in head and branch. dlgIndexConstraint::GetSql() was > hard-coded to > "PRIMARY KEY" instead of > wxString(typeList[objectType].typeName).Upper(). Cool, thanks. Did you get the frogfrog thing as well? I noticed that when adding a UNIQUE constraint from the table prop dialogue. Regards, Dave.
>>Fixed in head and branch. dlgIndexConstraint::GetSql() was >>hard-coded to >>"PRIMARY KEY" instead of >>wxString(typeList[objectType].typeName).Upper(). > > > Cool, thanks. Did you get the frogfrog thing as well? I noticed that > when adding a UNIQUE constraint from the table prop dialogue. > > Regards, Dave. Another possible thing you may have forgotten is dumping ALTER TABLE foo CLUSTER ON blah; statements for clustered indexes for 7.4 Chris
Thanks Chris, added to TODO. Regards, Dave. > -----Original Message----- > From: Christopher Kings-Lynne [mailto:chriskl@familyhealth.com.au] > Sent: 07 October 2003 08:27 > To: Dave Page > Cc: Andreas Pflug; Matej Rizman; pgadmin-support@postgresql.org > Subject: Re: [pgadmin-support] PgAdmin III: Two bugs > > > > >>Fixed in head and branch. dlgIndexConstraint::GetSql() was > >>hard-coded to > >>"PRIMARY KEY" instead of > >>wxString(typeList[objectType].typeName).Upper(). > > > > > > Cool, thanks. Did you get the frogfrog thing as well? I > noticed that > > when adding a UNIQUE constraint from the table prop dialogue. > > > > Regards, Dave. > > Another possible thing you may have forgotten is dumping > > ALTER TABLE foo CLUSTER ON blah; > > statements for clustered indexes for 7.4 > > Chris > > >
Dave Page wrote: > > > Did you get the frogfrog thing as well? I noticed that >when adding a UNIQUE constraint from the table prop dialogue. > This translates to what? My dictionary only knows single frogs, not siamesian twin frogs :-) Regards, Andreas
> -----Original Message----- > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > Sent: 07 October 2003 10:31 > To: Dave Page > Cc: pgadmin-support@postgresql.org > Subject: Re: [pgadmin-support] PgAdmin III: Two bugs > > > Dave Page wrote: > > > > > > > Did you get the frogfrog thing as well? I noticed that > >when adding a UNIQUE constraint from the table prop dialogue. > > > > This translates to what? My dictionary only knows single frogs, not > siamesian twin frogs :-) Lol! It translates to (which was in the bit you snipped!): > >it works fine apart from another > >bugette in which the name is doubled (ie frog becomes frogfrog). In other words, when I create a unique constraint from the table properties dialogue, it doubles the name. Regards, Dave.
Dave Page wrote: > > >>-----Original Message----- >>From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] >>Sent: 07 October 2003 10:31 >>To: Dave Page >>Cc: pgadmin-support@postgresql.org >>Subject: Re: [pgadmin-support] PgAdmin III: Two bugs >> >> >>Dave Page wrote: >> >> >> >>>Did you get the frogfrog thing as well? I noticed that >>>when adding a UNIQUE constraint from the table prop dialogue. >>> >>> >>> >>This translates to what? My dictionary only knows single frogs, not >>siamesian twin frogs :-) >> >> > >Lol! > >It translates to (which was in the bit you snipped!): > > > >>>it works fine apart from another >>>bugette in which the name is doubled (ie frog becomes frogfrog). >>> >>> > >In other words, when I create a unique constraint from the table >properties dialogue, it doubles the name. > Fixed in cvs and branch. Fixed in cvs and branch. Regards, AndreasAndreas