Thread: pgAdmin III Reverse Engineered SQL for RULES

pgAdmin III Reverse Engineered SQL for RULES

From
"Donald Fraser"
Date:
 
Haven't checked the latest version.
Running pgAdmin III 0.8.0 devel 3rd Aug.
 
Feature requests:
1)
The reverse engineered SQL code for RULES does not include the *normal* commented out -- DROP RULE ...
Which I find very handy in most of the other reverse engineered SQL code.
 
2)
RULES are displayed as CREATE RULE .....
Slightly more convenient would be CREATE OR REPLACE RULE ....
 
Regards
Donald Fraser.

Re: pgAdmin III Reverse Engineered SQL for RULES

From
"Dave Page"
Date:
 
-----Original Message-----
From: Donald Fraser [mailto:demolish@cwgsy.net]
Sent: 15 August 2003 00:51
To: [pgADMIN]
Subject: [pgadmin-support] pgAdmin III Reverse Engineered SQL for RULES

 
Haven't checked the latest version.
Running pgAdmin III 0.8.0 devel 3rd Aug.
 
Feature requests:
1)
The reverse engineered SQL code for RULES does not include the *normal* commented out -- DROP RULE ...
Which I find very handy in most of the other reverse engineered SQL code. 
 
Fixed. You can also now create DO INSTEAD NOTHING rules which were previously only possible if you padded out the definition with a few spaces or CRs. 
 
2)
RULES are displayed as CREATE RULE .....
Slightly more convenient would be CREATE OR REPLACE RULE ....
 
Not sure about the best way to fix this. In 7.3, the definition from PostgreSQL is run through some code to format it more nicely. We technically could insert OR REPLACE in there, but I'm not overly happy with solution. In 7.4, the definition comes straight from PostgreSQL.
 
Any thoughts Andreas?
 
Regards, Dave.

Re: pgAdmin III Reverse Engineered SQL for RULES

From
Andreas Pflug
Date:
Donald Fraser wrote:

>  
> Haven't checked the latest version.
> Running pgAdmin III 0.8.0 devel 3rd Aug.
>  
> Feature requests:
> 1)
> The reverse engineered SQL code for RULES does not include the 
> *normal* commented out -- DROP RULE ...
> Which I find very handy in most of the other reverse engineered SQL code.
>  
> 2)
> RULES are displayed as CREATE RULE .....
> Slightly more convenient would be CREATE OR REPLACE RULE ....

This both originated from the fact that the complete CREATE RULE is 
retrieved from the backend, instead of being compiled in pgAdmin3.

Both are corrected now.

Regards,
Andreas




Re: pgAdmin III Reverse Engineered SQL for RULES

From
"Dave Page"
Date:

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 15 August 2003 11:49
> To: Dave Page
> Cc: [pgADMIN]
> Subject: Re: [pgadmin-support] pgAdmin III Reverse Engineered
> SQL for RULES
>
>
> Um,
> did you notice that I already fixed it nearly two hours ago including
> reply to the list?

No, I haven't seen any reply on the list, and your last commit was 4
weeks ago.

Regards, Dave.


Re: pgAdmin III Reverse Engineered SQL for RULES

From
Andreas Pflug
Date:
Gosh,
didn't commit successfully, now it's conflicting.






Re: pgAdmin III Reverse Engineered SQL for RULES

From
Andreas Pflug
Date:
Dave Page wrote:

>  
>
>     -----Original Message-----
>     *From:* Donald Fraser [mailto:demolish@cwgsy.net]
>     *Sent:* 15 August 2003 00:51
>     *To:* [pgADMIN]
>     *Subject:* [pgadmin-support] pgAdmin III Reverse Engineered SQL
>     for RULES
>
>      
>     Haven't checked the latest version.
>     Running pgAdmin III 0.8.0 devel 3rd Aug.
>      
>     Feature requests:
>     1)
>     The reverse engineered SQL code for RULES does not include the
>     *normal* commented out -- DROP RULE ...
>     Which I find very handy in most of the other reverse engineered
>     SQL code. 
>      
>
> Fixed. You can also now create DO INSTEAD NOTHING rules which were 
> previously only possible if you padded out the definition with a few 
> spaces or CRs. 
>
>      
>     2)
>     RULES are displayed as CREATE RULE .....
>     Slightly more convenient would be CREATE OR REPLACE RULE ....
>      
>
> Not sure about the best way to fix this. In 7.3, the definition from 
> PostgreSQL is run through some code to format it more nicely. We 
> technically could insert OR REPLACE in there, but I'm not overly happy 
> with solution. In 7.4, the definition comes straight from PostgreSQL.
>  
> Any thoughts Andreas?
>  

Um,
did you notice that I already fixed it nearly two hours ago including 
reply to the list?

Regards,
Andreas


> Regards, Dave.