Thread: [pgAdmin4][runtime][patch]: Runtime not working in all platform

[pgAdmin4][runtime][patch]: Runtime not working in all platform

From
Neel Patel
Date:
Hi,

Please find attached patch file to fix the below issue.

Issue:-
Runtime was not working in all platform due to syntax error in javascript.
This issue was introduced due to below commit.

Prevent the user attempting to run external commands if the bin path is not configured. Fixes #1177

f78024808e80fef67de1aef5c97d1756c6771c0e


It is working in browser but Qt's web engine is not able to handle the error and goes into infinite loop of paint event which may crash the pgAdmin4 application.

Can you please review and commit this patch ?

Thanks,
Neel Patel
Attachment

Re: [pgAdmin4][runtime][patch]: Runtime not working in all platform

From
Dave Page
Date:
Thanks, applied.

On Mon, Aug 8, 2016 at 2:11 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi,
>
> Please find attached patch file to fix the below issue.
>
> Issue:-
> Runtime was not working in all platform due to syntax error in javascript.
> This issue was introduced due to below commit.
>
> Prevent the user attempting to run external commands if the bin path is not
> configured. Fixes #1177
>
> f78024808e80fef67de1aef5c97d1756c6771c0e
>
>
> It is working in browser but Qt's web engine is not able to handle the error
> and goes into infinite loop of paint event which may crash the pgAdmin4
> application.
>
> Can you please review and commit this patch ?
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company