[pgAdmin4][runtime][patch]: Runtime not working in all platform - Mailing list pgadmin-hackers

From Neel Patel
Subject [pgAdmin4][runtime][patch]: Runtime not working in all platform
Date
Msg-id CACCA4P1HeN9YL1Lpo-PSL9EVU7+xHneEP_ShHSTRQOkZDpnofQ@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][runtime][patch]: Runtime not working in all platform
List pgadmin-hackers
Hi,

Please find attached patch file to fix the below issue.

Issue:-
Runtime was not working in all platform due to syntax error in javascript.
This issue was introduced due to below commit.

Prevent the user attempting to run external commands if the bin path is not configured. Fixes #1177

f78024808e80fef67de1aef5c97d1756c6771c0e


It is working in browser but Qt's web engine is not able to handle the error and goes into infinite loop of paint event which may crash the pgAdmin4 application.

Can you please review and commit this patch ?

Thanks,
Neel Patel
Attachment

pgadmin-hackers by date:

Previous
From: Surinder Kumar
Date:
Subject: Re: [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type
Next
From: Surinder Kumar
Date:
Subject: Re: [pgAdmin4][Patch]: RM#1478 - Make code mirror text editor keyboard shortcuts consistent irrespective of platform type