Thread: [pgAdmin4][runtime][patch]: Compilation error with Qt4
Hi,
Please find attached patch file with the fix of below issues with runtime application.
- Compilation error with Qt4 as "QUrlQuery" class was introduced since Qt5.
- Client side download code has been removed as now we support server side download.
- We should not delete sender object inside slot. If we do so it may crash the application. To avoid this, we used Qt's "deleteLater" which will delete the objects once the processing of all the events have been done.
Do review it and let us know for comments.
Thanks,
Neel Patel
Attachment
Thanks - applied. On Sat, Jul 23, 2016 at 2:39 PM, Neel Patel <neel.patel@enterprisedb.com> wrote: > Hi, > > Please find attached patch file with the fix of below issues with runtime > application. > > Compilation error with Qt4 as "QUrlQuery" class was introduced since Qt5. > Client side download code has been removed as now we support server side > download. > We should not delete sender object inside slot. If we do so it may crash the > application. To avoid this, we used Qt's "deleteLater" which will delete the > objects once the processing of all the events have been done. > > Do review it and let us know for comments. > > Thanks, > Neel Patel > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company