Postgres Pro
Downloads
Home   >   mailing lists

[pgAdmin4][runtime][patch]: Compilation error with Qt4 - Mailing list pgadmin-hackers

From Neel Patel
Subject [pgAdmin4][runtime][patch]: Compilation error with Qt4
Date
Msg-id CACCA4P2GP-F=Rh1CJW0YXJt8E4vtQ9mBJZbGRuRsBSXEUmOgCA@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][runtime][patch]: Compilation error with Qt4  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi,

Please find attached patch file with the fix of below issues with runtime application.
  • Compilation error with Qt4 as "QUrlQuery" class was introduced since Qt5.
  • Client side download code has been removed as now we support server side download.
  • We should not delete sender object inside slot. If we do so it may crash the application. To avoid this, we used Qt's "deleteLater" which will delete the objects once the processing of all the events have been done.
Do review it and let us know for comments.

Thanks,
Neel Patel
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin IV : Unittest modular patch
Next
From: Neel Patel
Date:
Subject: [pgAdmin4][patch]: Fix for RM 1320