Thread: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)
PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)
From
Murtuza Zabuawala
Date:
Hi,
PFA patch to fix the issue in server port check constraint validation which was not allowing user to save port 65535. (RM#1388)
We have changed in server table definition hence user has to run "setup.py" again to fix the issue.
--
Regards,
Attachment
Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)
From
Dave Page
Date:
On Wed, Jun 22, 2016 at 7:14 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue in server port check constraint validation which > was not allowing user to save port 65535. (RM#1388) > > We have changed in server table definition hence user has to run "setup.py" > again to fix the issue. Hmm, I think we need to extend pgAdmin4.py to do that upgrade automatically, in the same way that it will automatically run setup if the database doesn't exist. Can we add a version check there, and upgrade if needed? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)
From
Murtuza Zabuawala
Date:
Sure.
--
Regards,
On Wed, Jun 22, 2016 at 1:35 PM, Dave Page <dpage@pgadmin.org> wrote:
On Wed, Jun 22, 2016 at 7:14 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue in server port check constraint validation which
> was not allowing user to save port 65535. (RM#1388)
>
> We have changed in server table definition hence user has to run "setup.py"
> again to fix the issue.
Hmm, I think we need to extend pgAdmin4.py to do that upgrade
automatically, in the same way that it will automatically run setup if
the database doesn't exist. Can we add a version check there, and
upgrade if needed?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)
From
Murtuza Zabuawala
Date:
Hi Dave,
I checked the code it's already implemented, pgAdmin4.py will upgrade schema automatically on subsequent run.
Thanks,
Murtuza
--
Regards,
On Wed, Jun 22, 2016 at 2:10 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Sure.--Regards,On Wed, Jun 22, 2016 at 1:35 PM, Dave Page <dpage@pgadmin.org> wrote:On Wed, Jun 22, 2016 at 7:14 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue in server port check constraint validation which
> was not allowing user to save port 65535. (RM#1388)
>
> We have changed in server table definition hence user has to run "setup.py"
> again to fix the issue.
Hmm, I think we need to extend pgAdmin4.py to do that upgrade
automatically, in the same way that it will automatically run setup if
the database doesn't exist. Can we add a version check there, and
upgrade if needed?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)
From
Dave Page
Date:
Ahh, yes - in pgadmin/__init__.py. Thanks, patch applied. On Wed, Jun 22, 2016 at 10:18 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > I checked the code it's already implemented, pgAdmin4.py will upgrade schema > automatically on subsequent run. > > Thanks, > Murtuza > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Wed, Jun 22, 2016 at 2:10 PM, Murtuza Zabuawala > <murtuza.zabuawala@enterprisedb.com> wrote: >> >> Sure. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Wed, Jun 22, 2016 at 1:35 PM, Dave Page <dpage@pgadmin.org> wrote: >>> >>> On Wed, Jun 22, 2016 at 7:14 AM, Murtuza Zabuawala >>> <murtuza.zabuawala@enterprisedb.com> wrote: >>> > Hi, >>> > >>> > PFA patch to fix the issue in server port check constraint validation >>> > which >>> > was not allowing user to save port 65535. (RM#1388) >>> > >>> > We have changed in server table definition hence user has to run >>> > "setup.py" >>> > again to fix the issue. >>> >>> Hmm, I think we need to extend pgAdmin4.py to do that upgrade >>> automatically, in the same way that it will automatically run setup if >>> the database doesn't exist. Can we add a version check there, and >>> upgrade if needed? >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company