Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4) - Mailing list pgadmin-hackers

From Murtuza Zabuawala
Subject Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)
Date
Msg-id CAKKotZQyi4TyD73dhqVCtw2hD3Z9gtCqwJB88WVg9U3QQGJ7XA@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Responses Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi Dave,

I checked the code it's already implemented, pgAdmin4.py will upgrade schema automatically on subsequent run.

Thanks,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Jun 22, 2016 at 2:10 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Sure.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Jun 22, 2016 at 1:35 PM, Dave Page <dpage@pgadmin.org> wrote:
On Wed, Jun 22, 2016 at 7:14 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue in server port check constraint validation which
> was not allowing user to save port 65535. (RM#1388)
>
> We have changed in server table definition hence user has to run "setup.py"
> again to fix the issue.

Hmm, I think we need to extend pgAdmin4.py to do that upgrade
automatically, in the same way that it will automatically run setup if
the database doesn't exist. Can we add a version check there, and
upgrade if needed?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Murtuza Zabuawala
Date:
Subject: Re: PATCH: To fix the issue of IntegrityError in server port defination (pgAdmin4)
Next
From: Harshal Dhumal
Date:
Subject: Re: Fix for issue RM1220 and RM 1221 [pgadmin4]