Thread: Evaluate Sellect2 cell options properly [pgadmin4]

Evaluate Sellect2 cell options properly [pgadmin4]

From
Harshal Dhumal
Date:
Hi,

There are two ways we can provide options for select2 cell either by extending select2 cell with "optionValues" array or by passing "options" (function or array) in column definition.

Generally, if we are passing "optionValues" to select2 cell then we should not look for "options" in column definition but still we were looking for "options". This was causing javascript code to break if "options" were not passed in column definition.

Error fixed:

TypeError: this.column.get(...) is not a function
(this.column.get('options'))(this) :





-- 
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

Re: Evaluate Sellect2 cell options properly [pgadmin4]

From
Ashesh Vashi
Date:
Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Fri, Jun 3, 2016 at 3:17 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

There are two ways we can provide options for select2 cell either by extending select2 cell with "optionValues" array or by passing "options" (function or array) in column definition.

Generally, if we are passing "optionValues" to select2 cell then we should not look for "options" in column definition but still we were looking for "options". This was causing javascript code to break if "options" were not passed in column definition.

Error fixed:

TypeError: this.column.get(...) is not a function
(this.column.get('options'))(this) :





-- 
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers