Re: Evaluate Sellect2 cell options properly [pgadmin4] - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject Re: Evaluate Sellect2 cell options properly [pgadmin4]
Date
Msg-id CAG7mmoyGH+QeuzHOroYBjw79hvnnzFCrjvFB1dpYmQOZMJF-xQ@mail.gmail.com
Whole thread Raw
In response to Evaluate Sellect2 cell options properly [pgadmin4]  (Harshal Dhumal <harshal.dhumal@enterprisedb.com>)
List pgadmin-hackers
Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Fri, Jun 3, 2016 at 3:17 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

There are two ways we can provide options for select2 cell either by extending select2 cell with "optionValues" array or by passing "options" (function or array) in column definition.

Generally, if we are passing "optionValues" to select2 cell then we should not look for "options" in column definition but still we were looking for "options". This was causing javascript code to break if "options" were not passed in column definition.

Error fixed:

TypeError: this.column.get(...) is not a function
(this.column.get('options'))(this) :





-- 
Harshal Dhumal
Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Proper evaluation of the optionsValues in the Backgri
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Fixes #1298 - ACL for the SEQUENCE node were not pars