Thread: Re: Patch for pgAdmin4 docs
Hi This seems to be missing the images. Did you remember to git add them, before diff'ing? On Tue, May 24, 2016 at 4:21 PM, Susan Douglas <susan.douglas@enterprisedb.com> wrote: > Hi All, > > I've attached a patch that updates the Foreign Table dialog - this patch does not address all of the problems in the indexfile (I'm hoping to get that cleaned up next week). > > Thanks! > > -- Susan > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
> On 24 May 2016, at 18:29, Susan Douglas <susan.douglas@enterprisedb.com> wrote: > > >> On May 24, 2016, at 12:02 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> Hi >> >> This seems to be missing the images. Did you remember to git add them, >> before diff'ing? > > I think the .png's are already checked in as part of the last patch... I don't think so (unless they've been renamed). I had errors about them from Sphinx. > > -- Susan > >> >> On Tue, May 24, 2016 at 4:21 PM, Susan Douglas >> <susan.douglas@enterprisedb.com> wrote: >>> Hi All, >>> >>> I've attached a patch that updates the Foreign Table dialog - this patch does not address all of the problems in theindex file (I'm hoping to get that cleaned up next week). >>> >>> Thanks! >>> >>> -- Susan >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >
On Tue, May 24, 2016 at 8:03 PM, Susan Douglas <susan.douglas@enterprisedb.com> wrote: > > I've created another patch (below) that adds the .rst and .png files, and includes an updated index.rst file that addsthe Foreign Table dialog. There are still errors related to the index, but I'd prefer to try to fix them in anotherpatch. Thanks. That worked, except the patch came across in DOS format, so I had to change the line endings first before it would apply. It's probably worth zipping the next one, to be on the safe side. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
> On May 24, 2016, at 12:02 PM, Dave Page <dpage@pgadmin.org> wrote: > > Hi > > This seems to be missing the images. Did you remember to git add them, > before diff'ing? I think the .png's are already checked in as part of the last patch... -- Susan > > On Tue, May 24, 2016 at 4:21 PM, Susan Douglas > <susan.douglas@enterprisedb.com> wrote: >> Hi All, >> >> I've attached a patch that updates the Foreign Table dialog - this patch does not address all of the problems in the indexfile (I'm hoping to get that cleaned up next week). >> >> Thanks! >> >> -- Susan >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company
> On May 24, 2016, at 2:31 PM, Dave Page <dpage@pgadmin.org> wrote: > > > >> On 24 May 2016, at 18:29, Susan Douglas <susan.douglas@enterprisedb.com> wrote: >> >> >>> On May 24, 2016, at 12:02 PM, Dave Page <dpage@pgadmin.org> wrote: >>> >>> Hi >>> >>> This seems to be missing the images. Did you remember to git add them, >>> before diff'ing? >> >> I think the .png's are already checked in as part of the last patch... > > I don't think so (unless they've been renamed). I had errors about them from Sphinx. I've created another patch (below) that adds the .rst and .png files, and includes an updated index.rst file that adds theForeign Table dialog. There are still errors related to the index, but I'd prefer to try to fix them in another patch. Thanks! -- Susan > >> >> -- Susan >> >>> >>> On Tue, May 24, 2016 at 4:21 PM, Susan Douglas >>> <susan.douglas@enterprisedb.com> wrote: >>>> Hi All, >>>> >>>> I've attached a patch that updates the Foreign Table dialog - this patch does not address all of the problems in theindex file (I'm hoping to get that cleaned up next week). >>>> >>>> Thanks! >>>> >>>> -- Susan >>>> >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>