Thread: [pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder

Hi,

PFA patch to fix the issue:
Unable to create extension "postgis_topology" and "postgis_tiger_geocoder", due to wrong schema name in generated SQL query.

For example:

It generates following query for 'postgis_toplology' extension:
CREATE EXTENSION postgis_topology SCHEMA topology;

which is wrong. the correct query should be:
CREATE EXTENSION postgis_topology;

where it fetches 'topology' schema from table pg_available_extensions and 
then sets schema when extension name is selected, but it should not set schema on name change.
It is now fixed in this patch.
Thanks Fahar for reporting.

Please review and let me know for comments.

Thanks,
Surinder Kumar
Attachment
Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Fri, May 6, 2016 at 4:32 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue:
Unable to create extension "postgis_topology" and "postgis_tiger_geocoder", due to wrong schema name in generated SQL query.

For example:

It generates following query for 'postgis_toplology' extension:
CREATE EXTENSION postgis_topology SCHEMA topology;

which is wrong. the correct query should be:
CREATE EXTENSION postgis_topology;

where it fetches 'topology' schema from table pg_available_extensions and 
then sets schema when extension name is selected, but it should not set schema on name change.
It is now fixed in this patch.
Thanks Fahar for reporting.

Please review and let me know for comments.

Thanks,
Surinder Kumar


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers