[pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder - Mailing list pgadmin-hackers

From Surinder Kumar
Subject [pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder
Date
Msg-id CAM5-9D88Ak8v-9kMiTzwmUgv4-=VK35vxrwPkf8t9rPkBv5KkQ@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][patch]: Unable to create extension "postgis_topology" and "postgis_tiger_geocoder" installed through stack builder  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
List pgadmin-hackers
Hi,

PFA patch to fix the issue:
Unable to create extension "postgis_topology" and "postgis_tiger_geocoder", due to wrong schema name in generated SQL query.

For example:

It generates following query for 'postgis_toplology' extension:
CREATE EXTENSION postgis_topology SCHEMA topology;

which is wrong. the correct query should be:
CREATE EXTENSION postgis_topology;

where it fetches 'topology' schema from table pg_available_extensions and 
then sets schema when extension name is selected, but it should not set schema on name change.
It is now fixed in this patch.
Thanks Fahar for reporting.

Please review and let me know for comments.

Thanks,
Surinder Kumar
Attachment

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: [pgAdmin4][Patch]: TODO File
Next
From: Akshay Joshi
Date:
Subject: Re: New committer: Akshay Joshi