Postgres Pro
Downloads
Home   >   mailing lists

Thread: Some trivial patch

Some trivial patch

From
Mads Jensen
Date:
A couple of improvements. I can compile without the wx/regex.h header on
Ubuntu 14.04, and also the WXK_SPACE works.

I still haven't fully grasped how the completion works. If you use the
psql command tool, completion happens at more places than what is
offered by pgadmin, e.g., join. I found the utils/tabcomplete.c file.
--
Med Venlig Hilsen / Kind regards,
Mads Jensen

Max Jerry Horovitz: "Unfortunately, in America, babies are not found in
cola cans. I asked my mother when I was four and she said they came from
eggs laid by rabbis. If you aren't Jewish, they're laid by Catholic
nuns. If you're an atheist, they're laid by dirty, lonely prostitutes."
         -- Mary and Max (2009)
Attachment

Re: Some trivial patch

From
"J.F. Oster"
Date:
Hello,

Regarding the patch, I confirm successful build on Windows and Ubuntu.

Monday, November 3, 2014, 11:53:50 AM, Mads Jensen wrote:

MJ> A couple of improvements. I can compile without the wx/regex.h header on
MJ> Ubuntu 14.04, and also the WXK_SPACE works.

MJ> I still haven't fully grasped how the completion works. If you use the
MJ> psql command tool, completion happens at more places than what is
MJ> offered by pgadmin, e.g., join. I found the utils/tabcomplete.c file.



--
Best regards,
 J.F.

Re: Some trivial patch

From
Ashesh Vashi
Date:
Hi Mads,

What is the exact improvement?
I did not understand from the patch.

Was the existing code not working properly?


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Mon, Nov 3, 2014 at 7:04 PM, J.F. Oster <jinfroster@mail.ru> wrote:
Hello,

Regarding the patch, I confirm successful build on Windows and Ubuntu.

Monday, November 3, 2014, 11:53:50 AM, Mads Jensen wrote:

MJ> A couple of improvements. I can compile without the wx/regex.h header on
MJ> Ubuntu 14.04, and also the WXK_SPACE works.

MJ> I still haven't fully grasped how the completion works. If you use the
MJ> psql command tool, completion happens at more places than what is
MJ> offered by pgadmin, e.g., join. I found the utils/tabcomplete.c file.



--
Best regards,
 J.F.



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: Some trivial patch

From
Ashesh Vashi
Date:
Hi Mads,

As per our discussion, it is not improvement.
But - it is a unused inclusion of header, and usage of proper macro provided by wxWidgets.

Committed the patch.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Tue, Nov 4, 2014 at 9:53 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Mon, Nov 3, 2014 at 7:38 PM, Mads Jensen <mje@inducks.org> wrote:
On 11/03/2014 02:42 PM, Ashesh Vashi wrote:
> Hi Mads,
>
> What is the exact improvement?
> I did not understand from the patch.
>
> Was the existing code not working properly?

Yes, but aren't unnecessary imports (with misleading comments) deprecated?
Yes - it is.
But - I was confused by the subject line, and missing (incomplete) description.

--
Med Venlig Hilsen / Kind regards,
Mads Jensen

Max Jerry Horovitz: "Unfortunately, in America, babies are not found in
cola cans. I asked my mother when I was four and she said they came from
eggs laid by rabbis. If you aren't Jewish, they're laid by Catholic
nuns. If you're an atheist, they're laid by dirty, lonely prostitutes."
         -- Mary and Max (2009)