Thread: PATCH: wxDatePickerCtrl also stores time along with date
Hi All,
We found an issue related to using wxDatePickerCtrl instead of wxCalendarBox.
Actually - wxDatePickerCtrl does saves the time too, and that's why while using it, it also add up time from the control in update SQL(s).
Because of that, the following scenario happens:
- Create a job 'a'
- Create a schedule 's1' for it.
Start-time: 28/11/12 15:00:00
End-time: 28/11/12 15:05:00
- Re-open the properties for the schedule 's1'.
It will show an update query.
Even - if you don't change the start/end date-time.
That's because the calStart (a wxDatePickerCtrl object) has the value with time, and when GetUpdateSql gets called - the result for 'calStart->GetValue() + timStart->GetValue()' would be '29/11/12 06:00:00', which is not equal to the actual value. Hence - generate wrong value.
Please find the patch to resolve the issue.
Attachment
Thanks, patch applied. On Wed, Nov 28, 2012 at 12:20 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: > Hi All, > > We found an issue related to using wxDatePickerCtrl instead of > wxCalendarBox. > Actually - wxDatePickerCtrl does saves the time too, and that's why while > using it, it also add up time from the control in update SQL(s). > > Because of that, the following scenario happens: > - Create a job 'a' > - Create a schedule 's1' for it. > Start-time: 28/11/12 15:00:00 > End-time: 28/11/12 15:05:00 > - Re-open the properties for the schedule 's1'. > It will show an update query. > Even - if you don't change the start/end date-time. > > That's because the calStart (a wxDatePickerCtrl object) has the value with > time, and when GetUpdateSql gets called - the result for > 'calStart->GetValue() + timStart->GetValue()' would be '29/11/12 06:00:00', > which is not equal to the actual value. Hence - generate wrong value. > > Please find the patch to resolve the issue. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > http://www.linkedin.com/in/asheshvashi > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Thanks
-- Ashesh
On Wed, Nov 28, 2012 at 10:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.> --
On Wed, Nov 28, 2012 at 12:20 PM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Hi All,
>
> We found an issue related to using wxDatePickerCtrl instead of
> wxCalendarBox.
> Actually - wxDatePickerCtrl does saves the time too, and that's why while
> using it, it also add up time from the control in update SQL(s).
>
> Because of that, the following scenario happens:
> - Create a job 'a'
> - Create a schedule 's1' for it.
> Start-time: 28/11/12 15:00:00
> End-time: 28/11/12 15:05:00
> - Re-open the properties for the schedule 's1'.
> It will show an update query.
> Even - if you don't change the start/end date-time.
>
> That's because the calStart (a wxDatePickerCtrl object) has the value with
> time, and when GetUpdateSql gets called - the result for
> 'calStart->GetValue() + timStart->GetValue()' would be '29/11/12 06:00:00',
> which is not equal to the actual value. Hence - generate wrong value.
>
> Please find the patch to resolve the issue.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>
>
>
> http://www.linkedin.com/in/asheshvashi
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company