PATCH: wxDatePickerCtrl also stores time along with date - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject PATCH: wxDatePickerCtrl also stores time along with date
Date
Msg-id CAG7mmoz9tfrOmWp+2=yzwmKJFaCF7s9O+p45L3CAikTJCD3mnQ@mail.gmail.com
Whole thread Raw
Responses Re: PATCH: wxDatePickerCtrl also stores time along with date  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi All,

We found an issue related to using wxDatePickerCtrl instead of wxCalendarBox.
Actually - wxDatePickerCtrl does saves the time too, and that's why while using it, it also add up time from the control in update SQL(s).

Because of that, the following scenario happens:
- Create a job 'a'
- Create a schedule 's1' for it.
    Start-time: 28/11/12 15:00:00
    End-time:   28/11/12 15:05:00
- Re-open the properties for the schedule 's1'.
  It will show an update query.
  Even - if you don't change the start/end date-time.

  That's because the calStart (a wxDatePickerCtrl object) has the value with time, and when GetUpdateSql gets called - the result for 'calStart->GetValue() + timStart->GetValue()' would be '29/11/12 06:00:00', which is not equal to the actual value. Hence - generate wrong value.

Please find the patch to resolve the issue.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:
Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Fixed documentation warnings
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Date picker controls returns a full timestamp by