Thread: [pgAdmin III] #209: "Connect to Server" dialog buggy

#209: "Connect to Server" dialog buggy
------------------------+---------------------------------------------------
 Reporter:  brsa        |       Owner:  dpage  
     Type:  bug         |      Status:  new    
 Priority:  major       |   Milestone:  1.12   
Component:  pgadmin     |     Version:         
 Keywords:  SQL editor  |    Platform:  windows
------------------------+---------------------------------------------------
 Testing v1.12beta3 (rev. 8448) on Windows XP Pro. Server = pg 8.4.4 on
 Debian Lenny.

 In the SQL editor try to connect to another server by choosing "new
 connection" from the connection combobox.

 - Selecting a different server triggers an immediate attempt to connect.
 (happens sometimes)

 The "Username" combobox behaves differently from the 2 other comboboxes:
 - The first user shown is the alphabetically first in the list, but it
 should be the user of the same name as in the current connection - if such
 a user exists. (happens always)
 - A click into the field does not open the list. (happens always)
 - Typed text is not completed, not even after moving the focus to another
 control. Only after clicking on the down arrow. (happens always)
 - This way I can enter non-existing users and try to connect with these.
 - pgAdmin randomly crashes when I try to use the feature. (happens
 sometimes)

 I had to try like 6 times, 3 times of which pgadmin crashed completely
 until I managed to open another connection.

 Wishlist item: a way to close a connection without closing the SQL editor
 window.

--
Ticket URL: <http://code.pgadmin.org/trac/ticket/209>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III

#209: "Connect to Server" dialog buggy
------------------------+---------------------------------------------------
 Reporter:  brsa        |       Owner:  ashesh  
     Type:  bug         |      Status:  assigned
 Priority:  major       |   Milestone:  1.12    
Component:  pgadmin     |     Version:          
 Keywords:  SQL editor  |    Platform:  windows 
------------------------+---------------------------------------------------
Changes (by dpage):

  * owner:  dpage => ashesh
  * status:  new => assigned


--
Ticket URL: <http://code.pgadmin.org/trac/ticket/209#comment:1>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III

Le 12/07/2010 02:50, pgAdmin Trac a écrit :
> [...]
>  Wishlist item: a way to close a connection without closing the SQL editor
>  window.
>

Another one on "how to use a bugtracker" :)

You should have made two tickets for this one, one for the wishlist
item, and one for the bug. They won't have the same version and
milestone. They also won't have the same code patch. Etc, etc.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

#209: "Connect to Server" dialog buggy
-----------------------+----------------------------------------------------
 Reporter:  brsa       |       Owner:  ashesh  
     Type:  bug        |      Status:  assigned
 Priority:  major      |   Milestone:  1.12    
Component:  pgadmin    |     Version:          
 Keywords:  querytool  |    Platform:  windows 
-----------------------+----------------------------------------------------
Changes (by gleu):

  * keywords:  SQL editor => querytool


Old description:

> Testing v1.12beta3 (rev. 8448) on Windows XP Pro. Server = pg 8.4.4 on
> Debian Lenny.
>
> In the SQL editor try to connect to another server by choosing "new
> connection" from the connection combobox.
>
> - Selecting a different server triggers an immediate attempt to connect.
> (happens sometimes)
>
> The "Username" combobox behaves differently from the 2 other comboboxes:
> - The first user shown is the alphabetically first in the list, but it
> should be the user of the same name as in the current connection - if
> such a user exists. (happens always)
> - A click into the field does not open the list. (happens always)
> - Typed text is not completed, not even after moving the focus to another
> control. Only after clicking on the down arrow. (happens always)
> - This way I can enter non-existing users and try to connect with these.
> - pgAdmin randomly crashes when I try to use the feature. (happens
> sometimes)
>
> I had to try like 6 times, 3 times of which pgadmin crashed completely
> until I managed to open another connection.
>
> Wishlist item: a way to close a connection without closing the SQL editor
> window.

New description:

 Testing v1.12beta3 (rev. 8448) on Windows XP Pro. Server = pg 8.4.4 on
 Debian Lenny.

 In the SQL editor try to connect to another server by choosing "new
 connection" from the connection combobox.

 - Selecting a different server triggers an immediate attempt to connect.
 (happens sometimes)

 The "Username" combobox behaves differently from the 2 other comboboxes:
 - The first user shown is the alphabetically first in the list, but it
 should be the user of the same name as in the current connection - if such
 a user exists. (happens always)
 - A click into the field does not open the list. (happens always)
 - Typed text is not completed, not even after moving the focus to another
 control. Only after clicking on the down arrow. (happens always)
 - This way I can enter non-existing users and try to connect with these.
 - pgAdmin randomly crashes when I try to use the feature. (happens
 sometimes)

 I had to try like 6 times, 3 times of which pgadmin crashed completely
 until I managed to open another connection.

--

Comment:

 The wishlist item has been removed from this ticket. The ticket #211 will
 deal with it.

--
Ticket URL: <http://code.pgadmin.org/trac/ticket/209#comment:2>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III

On Mon, Jul 12, 2010 at 11:39 AM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
> Hi Dave,
> Please find the patch for the same.

Thanks. This looks good to me following some quick testing, but I
uncovered some other issues - could you look at them please?

- We seem to stop populating the server combo box as soon as we find
the one we're currently connected to. This happens at ~ line 286 in
dlgSelectConnection.cpp, where we set foundServer = true. I can't see
why we do this, but it seems fairly deliberate. Any guesses? Should we
just remove that?

- It seems like we ignore sslmode when we create new connections. We
need to honour the server config.

Note that I haven't tested to ensure this doesn't break anything in
command line startup mode (eg. with -q). Can you please ensure this
mode is unaffected?

Thanks.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

Thanks - applied.

On Mon, Jul 12, 2010 at 1:21 PM, Ashesh Vashi
<ashesh.vashi@enterprisedb.com> wrote:
>
> Hi Dave,
> PFA the updated patch.
> [Please check my inline answers.]
>
> On Mon, Jul 12, 2010 at 4:37 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Mon, Jul 12, 2010 at 11:39 AM, Ashesh Vashi
>> <ashesh.vashi@enterprisedb.com> wrote:
>> > Hi Dave,
>> > Please find the patch for the same.
>>
>> Thanks. This looks good to me following some quick testing, but I
>> uncovered some other issues - could you look at them please?
>>
>> - We seem to stop populating the server combo box as soon as we find
>> the one we're currently connected to. This happens at ~ line 286 in
>> dlgSelectConnection.cpp, where we set foundServer = true. I can't see
>> why we do this, but it seems fairly deliberate. Any guesses? Should we
>> just remove that?
>
> My mistake - I introduced that variable in the previous patch.
>>
>> - It seems like we ignore sslmode when we create new connections. We
>> need to honour the server config.
>
> Done.
>>
>> Note that I haven't tested to ensure this doesn't break anything in
>> command line startup mode (eg. with -q). Can you please ensure this
>> mode is unaffected?
>
> Tested.
> --
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise Postgres Company
>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise Postgres Company
>
>



--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company

#209: "Connect to Server" dialog buggy
----------------------+-----------------------------------------------------
  Reporter:  brsa     |       Owner:  ashesh   
      Type:  bug      |      Status:  closed   
  Priority:  major    |   Milestone:  1.12     
 Component:  pgadmin  |     Version:           
Resolution:  fixed    |    Keywords:  querytool
  Platform:  windows  |  
----------------------+-----------------------------------------------------
Changes (by gleu):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 Fixed in r8467.

--
Ticket URL: <http://code.pgadmin.org/trac/ticket/209#comment:3>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III