Thread: bug report
hi When column name has commas, using the data grid to insert row will causes error. For test, I defined column named "quoted col ,""' name". A printscreen in attachment. By the way: I had implemented TODO Item: - Add support for DESC/NULLS FIRST/NULLS LAST when creating indexes. It seems work fine. I will test it next two days, and plan to submit at weekend. ----------------------------------------------- Quan Zongliang quanzongliang@gmail.com CIT Japan: http://www.cit.co.jp
Attachment
Sorry, my mistake. This error is caused by double quotation mark, not comma. > When column name has commas, using the data grid to insert row will > causes error. > For test, I defined column named "quoted col ,""' name". > A printscreen in attachment. ----------------------------------------------- Quan Zongliang quanzongliang@gmail.com CIT Japan: http://www.cit.co.jp
On Thu, Nov 13, 2008 at 2:13 AM, Quan Zongliang <quanzongliang@gmail.com> wrote: > Sorry, my mistake. > > This error is caused by double quotation mark, not comma. Are you in a position to fix it? Your last patch was good, and we always welcome new hackers :-) -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
> > Are you in a position to fix it? Your last patch was good, and we > always welcome new hackers :-) Ok, fixed. ----------------------------------------------- Quan Zongliang quanzongliang@gmail.com CIT Japan: http://www.cit.co.jp
Attachment
On Thu, Nov 13, 2008 at 11:01 AM, Quan Zongliang <quanzongliang@gmail.com> wrote: >> >> Are you in a position to fix it? Your last patch was good, and we >> always welcome new hackers :-) > > Ok, fixed. Thanks... but, now I come to test it, I cannot reproduce the problem. Were you testing with SVN trunk, or a release version of pgAdmin? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
> > Thanks... but, now I come to test it, I cannot reproduce the problem. > Were you testing with SVN trunk, or a release version of pgAdmin? I had tested at release 1.8.4 and 1.9.0-dev. The target column is nullable, input some value in other columns and press Enter key. The error will be thrown. Sorry, my English is very poor, it is difficult for me to write a long detailed description. ----------------------------------------------- Quan Zongliang quanzongliang@gmail.com CIT Japan: http://www.cit.co.jp
On Fri, Nov 14, 2008 at 10:37 AM, Quan Zongliang <quanzongliang@gmail.com> wrote: > >> >> Thanks... but, now I come to test it, I cannot reproduce the problem. >> Were you testing with SVN trunk, or a release version of pgAdmin? > > I had tested at release 1.8.4 and 1.9.0-dev. > The target column is nullable, input some value in other columns and > press Enter key. The error will be thrown. OK, this is weird. This is my test table: CREATE TABLE foo ( id serial NOT NULL, "a,b,c" boolean, "foo""with a quote" text, "quoted col ,""""' name" text, CONSTRAINT foo_pkey PRIMARY KEY (id) ) WITH (OIDS=FALSE); ALTER TABLE foo OWNER TO postgres; That seems to work fine in the editor on PG 8.3.4 (really must upgrade that!) using pgAdmin 1.8.4 and SVN trunk on OS X. What server version and OS are you using? Can anyone else reproduce this? > Sorry, my English is very poor, it is difficult for me to write a long > detailed description. Your English is much better than my Japanese :-) -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Attachment is the most important debug info. I forgot it. From it, I know how to modify source. ----------------------------------------------- Quan Zongliang quanzongliang@gmail.com CIT Japan: http://www.cit.co.jp
Attachment
> > That seems to work fine in the editor on PG 8.3.4 (really must upgrade > that!) using pgAdmin 1.8.4 and SVN trunk on OS X. What server version > and OS are you using? Can anyone else reproduce this? I tested it in CentOS 5.2 and Windows XP, both got error. The attachment is snapshot in KDE. DB version: 8.3.5 pgAdmin: 1.8.4 In Windows XP: DB: 8.2.11 and 8.3.5 pgAdmin: 1.8.4 and 1.9.0-dev ----------------------------------------------- Quan Zongliang quanzongliang@gmail.com CIT Japan: http://www.cit.co.jp
Attachment
On Sat, Nov 15, 2008 at 6:39 AM, Quan Zongliang <quanzongliang@gmail.com> wrote: > > Attachment is the most important debug info. I forgot it. > > From it, I know how to modify source. Ahh, I got it. The bug doesn't occur unless you manually specify the primary key value (which I normally leave up to the sequence to supply). Bug verified, and fix applied to SVN. Thanks!! -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com