Thread: Re: SUN Studio 11 vs pgAdmin - code cleanup]
> -----Original Message----- > From: Zdenek.Kotala@Sun.COM [mailto:Zdenek.Kotala@Sun.COM] > Sent: 18 August 2006 15:53 > To: Dave Page > Cc: pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] SUN Studio 11 vs pgAdmin - > code cleanup] > > Zdenek Kotala napsal(a): > > Dave Page wrote: > > > >> > >> Thanks - patch applied to the stable branch. Would you > mind taking some > >> time to port the patch to SVN TRUNK please? It's most > likely that that > >> will go beta within a few weeks and unfortunately I'm > *really* pushed > >> for time right now :-( > >> > > > > Ok. No problem. I will do it. > > There is clean up for the trunk. Thanks - patch applied, except for the updates to tabcomplete.inc which is extracted from the PostgreSQL source code periodically (see src/utils/tabcomplete.pl in pgAdmin - particularly the comment towards the top). Regards, Dave.
Dave Page napsal(a):
>
>
>> -----Original Message-----
>> From: Zdenek.Kotala@Sun.COM [mailto:Zdenek.Kotala@Sun.COM]
>> Sent: 18 August 2006 15:53
>> To: Dave Page
>> Cc: pgadmin-hackers@postgresql.org
>> Subject: Re: [pgadmin-hackers] SUN Studio 11 vs pgAdmin -
>> code cleanup]
>>
>> Zdenek Kotala napsal(a):
>>> Dave Page wrote:
>>>
>>>> Thanks - patch applied to the stable branch. Would you
>> mind taking some
>>>> time to port the patch to SVN TRUNK please? It's most
>> likely that that
>>>> will go beta within a few weeks and unfortunately I'm
>> *really* pushed
>>>> for time right now :-(
>>>>
>>> Ok. No problem. I will do it.
>> There is clean up for the trunk.
>
> Thanks - patch applied, except for the updates to tabcomplete.inc which
> is extracted from the PostgreSQL source code periodically (see
> src/utils/tabcomplete.pl in pgAdmin - particularly the comment towards
> the top).
OK, but tabcomplete.inc has DOS end lines. It is problematic. When C/C++
code contents strings concatenate on two lines, CC generates error in
this case. There are three possible solutions:
1) use dos2unix (or something similar) during file transfer/generation
2) use dos2unix like part of Make process
3) fix/adjust CC/cc
I prefer option 1.
Zdenek
> -----Original Message----- > From: Zdenek.Kotala@Sun.COM [mailto:Zdenek.Kotala@Sun.COM] > Sent: 22 August 2006 08:39 > To: Dave Page > Cc: pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] SUN Studio 11 vs pgAdmin - > code cleanup] > > OK, but tabcomplete.inc has DOS end lines. It is problematic. > When C/C++ > code contents strings concatenate on two lines, CC generates error in > this case. There are three possible solutions: > > 1) use dos2unix (or something similar) during file transfer/generation > 2) use dos2unix like part of Make process > 3) fix/adjust CC/cc > > I prefer option 1. Yes, however I wonder if it gained those line endings because the last time it was built was on a Windows box (if there were DOS line endings in the original file, I'm sure Tom or Bruce would have yelped). Can you try regenerating it? Regards, Dave.