Postgres Pro
Downloads
Home   >   mailing lists

Thread: SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base

SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base

From
svn@pgadmin.org
Date:
Author: dpage

Date: 2006-02-17 11:05:34 +0000 (Fri, 17 Feb 2006)

New Revision: 5003

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5003&view=rev

Log:
Mask the password when logging the connection string.


Modified:
   trunk/pgadmin3/CHANGELOG
   trunk/pgadmin3/src/base/pgConnBase.cpp

Re: SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base

From
Kris Jurka
Date:
svn@pgadmin.org wrote:
> Author: dpage
>
> Date: 2006-02-17 11:05:34 +0000 (Fri, 17 Feb 2006)
>
> New Revision: 5003
>
> Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5003&view=rev
>
> Log:
> Mask the password when logging the connection string.
>

This crashes for debug builds.  Need to use .c_str() on the cleanConnStr.

Kris Jurka
Index: src/base/pgConnBase.cpp
===================================================================
*** src/base/pgConnBase.cpp    (revision 5006)
--- src/base/pgConnBase.cpp    (working copy)
***************
*** 170,176 ****
      // Open the connection
      wxString cleanConnStr = connstr;
      cleanConnStr.Replace(qtConnString(password), wxT("'XXXXXX'"));
!     wxLogInfo(wxT("Opening connection with connection string: %s"), cleanConnStr);
  
  #if wxUSE_UNICODE
      wxCharBuffer cstrUTF=connstr.mb_str(wxConvUTF8);
--- 170,176 ----
      // Open the connection
      wxString cleanConnStr = connstr;
      cleanConnStr.Replace(qtConnString(password), wxT("'XXXXXX'"));
!     wxLogInfo(wxT("Opening connection with connection string: %s"), cleanConnStr.c_str());
  
  #if wxUSE_UNICODE
      wxCharBuffer cstrUTF=connstr.mb_str(wxConvUTF8);

Re: SVN Commit by dpage: r5003 - in trunk/pgadmin3:

From
Andreas Pflug
Date:
Kris Jurka wrote:
> svn@pgadmin.org wrote:
>
>> Author: dpage
>>
>> Date: 2006-02-17 11:05:34 +0000 (Fri, 17 Feb 2006)
>>
>> New Revision: 5003
>>
>> Revision summary:
>> http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5003&view=rev
>>
>> Log:
>> Mask the password when logging the connection string.
>>
>
> This crashes for debug builds.  Need to use .c_str() on the cleanConnStr.

Hmpf, seems we had a small testing problem on the last patches...
Fixed in SVN, thanks for reporting.

Regards,
Andreas

Re: SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base

From
"Dave Page"
Date:

-----Original Message-----
From: "Andreas Pflug"<pgadmin@pse-consulting.de>
Sent: 19/02/06 19:57:13
To: "Kris Jurka"<books@ejurka.com>
Cc: "dpage@vale-housing.co.uk"<dpage@vale-housing.co.uk>,
"pgadmin-hackers@postgresql.org"<pgadmin-hackers@postgresql.org>
Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base

> Hmpf, seems we had a small testing problem on the last patches...

Hmm, worked fine in VC. I wonder if we can "borrow" the PG buildfarm code and make our own farm. Guess I'd need to fix
themingw build first... 

> Fixed in SVN, thanks for reporting.

Yes, thanks.

Regards, Dave

-----Unmodified Original Message-----
Kris Jurka wrote:
> svn@pgadmin.org wrote:
>
>> Author: dpage
>>
>> Date: 2006-02-17 11:05:34 +0000 (Fri, 17 Feb 2006)
>>
>> New Revision: 5003
>>
>> Revision summary:
>> http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5003&view=rev
>>
>> Log:
>> Mask the password when logging the connection string.
>>
>
> This crashes for debug builds.  Need to use .c_str() on the cleanConnStr.

Hmpf, seems we had a small testing problem on the last patches...
Fixed in SVN, thanks for reporting.

Regards,
Andreas