Re: SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base - Mailing list pgadmin-hackers

From Kris Jurka
Subject Re: SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base
Date
Msg-id 43F8ABCD.2020506@ejurka.com
Whole thread Raw
In response to SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base  (svn@pgadmin.org)
Responses Re: SVN Commit by dpage: r5003 - in trunk/pgadmin3:  (Andreas Pflug <pgadmin@pse-consulting.de>)
List pgadmin-hackers
svn@pgadmin.org wrote:
> Author: dpage
>
> Date: 2006-02-17 11:05:34 +0000 (Fri, 17 Feb 2006)
>
> New Revision: 5003
>
> Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5003&view=rev
>
> Log:
> Mask the password when logging the connection string.
>

This crashes for debug builds.  Need to use .c_str() on the cleanConnStr.

Kris Jurka
Index: src/base/pgConnBase.cpp
===================================================================
*** src/base/pgConnBase.cpp    (revision 5006)
--- src/base/pgConnBase.cpp    (working copy)
***************
*** 170,176 ****
      // Open the connection
      wxString cleanConnStr = connstr;
      cleanConnStr.Replace(qtConnString(password), wxT("'XXXXXX'"));
!     wxLogInfo(wxT("Opening connection with connection string: %s"), cleanConnStr);
  
  #if wxUSE_UNICODE
      wxCharBuffer cstrUTF=connstr.mb_str(wxConvUTF8);
--- 170,176 ----
      // Open the connection
      wxString cleanConnStr = connstr;
      cleanConnStr.Replace(qtConnString(password), wxT("'XXXXXX'"));
!     wxLogInfo(wxT("Opening connection with connection string: %s"), cleanConnStr.c_str());
  
  #if wxUSE_UNICODE
      wxCharBuffer cstrUTF=connstr.mb_str(wxConvUTF8);

pgadmin-hackers by date:

Previous
From: Andreas Pflug
Date:
Subject: Re: SVN Commit by dpage: r5000 - in trunk/pgadmin3:
Next
From: Kris Jurka
Date:
Subject: detecting serials in 8.1