Thread: Re: SVN Commit by dpage: r4884 - in trunk/pgadmin3:

Re: SVN Commit by dpage: r4884 - in trunk/pgadmin3:

From
"Dave Page"
Date:

> -----Original Message-----
> From: Miha Radej [mailto:miha.radej@siix.com]
> Sent: 09 January 2006 15:16
> To: Dave Page
> Cc: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r4884 -
> in trunk/pgadmin3:
>
> hi!
>
> Dave Page wrote:
> >>after checking out revision 4884 make fails with the
> following error:
> >>
> > <snip>
> >
> >>revision 4883 makes just fine.
> >>
> >>system is suse 9.3, gcc 3.3.4, wx 2.6.0.
> >>
> >>regards,
> >>Miha
> >
> > Does it build if you add 'include "frmQuery.h"' at the top of
> > pgAdmin3.cpp (see how frmMain and some others are already included)?
>
> i have just been playing around and tried doing that :) no
> luck, though:
>

OK, give me a few minutes - I'm just rebuilding my Slackware box -
almost there now. It's most certainly a header issue - Magnus' patch was
built on Windows, which I also tested it on, however Windows has
precompiled headers which normally means we only need to include
pgadmin3.h in each file.

/D

Re: SVN Commit by dpage: r4884 - in trunk/pgadmin3:

From
Miha Radej
Date:
hi!

i've tinkered around a bit and it seems to work with the attached patch
applied. "pgadmin -q" displayed the usage screen so i guess it should work.

cheers,
Miha

Dave Page wrote:
>>>>after checking out revision 4884 make fails with the
>>following error:
>>><snip>
>>>
>>>>revision 4883 makes just fine.
>>>>
>>>>system is suse 9.3, gcc 3.3.4, wx 2.6.0.
>>>>
>>>>regards,
>>>>Miha
>>>Does it build if you add 'include "frmQuery.h"' at the top of
>>>pgAdmin3.cpp (see how frmMain and some others are already included)?
>>i have just been playing around and tried doing that :) no
>>luck, though:
>>
>
> OK, give me a few minutes - I'm just rebuilding my Slackware box -
> almost there now. It's most certainly a header issue - Magnus' patch was
> built on Windows, which I also tested it on, however Windows has
> precompiled headers which normally means we only need to include
> pgadmin3.h in each file.
Index: src/pgAdmin3.cpp
===================================================================
--- src/pgAdmin3.cpp    (revision 4885)
+++ src/pgAdmin3.cpp    (working copy)
@@ -49,6 +49,8 @@
 #include "frmMain.h"
 #include "frmConfig.h"
 #include "frmSplash.h"
+#include "frmQuery.h"
+#include "pgServer.h"
 #include <wx/dir.h>
 #include <wx/fs_zip.h>
 #include "ctl/xh_calb.h"