Thread: Bug in dlgServer

Bug in dlgServer

From
Alexander Borkowski
Date:
Dear all,

I just encountered a bug in 1.2.0 Beta 2 (Win XP).

When adding a new server and selecting "require" in the SSL combobox for
a server that does in fact not support SSL, the following happens after
submitting the dialog: An error dialog informing about what just went
wrong comes up and after that the new server dialog comes up again
(which is all very good), but this time the the options for SSL are
showing twice. This is because in dlgServer::Go the options are appended
to cbSSL regardles whether they already are there or not. I was able to
fix this by wrapping the first few lines (until the #endif) of
dlgServer::Go in an

if (cbSSL->IsEmpty())
{
/* ... */
}

statement.

Regards,

Alex

Re: Bug in dlgServer

From
Andreas Pflug
Date:
Alexander Borkowski wrote:
> Dear all,
>
> I just encountered a bug in 1.2.0 Beta 2 (Win XP).
>
> When adding a new server and selecting "require" in the SSL combobox for
> a server that does in fact not support SSL, the following happens after
> submitting the dialog: An error dialog informing about what just went
> wrong comes up and after that the new server dialog comes up again
> (which is all very good), but this time the the options for SSL are
> showing twice. This is because in dlgServer::Go the options are appended
> to cbSSL regardles whether they already are there or not. I was able to
> fix this by wrapping the first few lines (until the #endif) of
> dlgServer::Go in an
>
> if (cbSSL->IsEmpty())
> {
> /* ... */
> }

It's even better not to call Go() from GoNew in that case, to prevent
*any* duplicate initialization (e.g. dlg positioning).

Fixed in cvs, thanks for reporting.

Regards,
Andreas