Re: Bug in dlgServer - Mailing list pgadmin-hackers

From Andreas Pflug
Subject Re: Bug in dlgServer
Date
Msg-id 41650ED1.5040207@pse-consulting.de
Whole thread Raw
In response to Bug in dlgServer  (Alexander Borkowski <alexander.borkowski@abri.une.edu.au>)
List pgadmin-hackers
Alexander Borkowski wrote:
> Dear all,
>
> I just encountered a bug in 1.2.0 Beta 2 (Win XP).
>
> When adding a new server and selecting "require" in the SSL combobox for
> a server that does in fact not support SSL, the following happens after
> submitting the dialog: An error dialog informing about what just went
> wrong comes up and after that the new server dialog comes up again
> (which is all very good), but this time the the options for SSL are
> showing twice. This is because in dlgServer::Go the options are appended
> to cbSSL regardles whether they already are there or not. I was able to
> fix this by wrapping the first few lines (until the #endif) of
> dlgServer::Go in an
>
> if (cbSSL->IsEmpty())
> {
> /* ... */
> }

It's even better not to call Go() from GoNew in that case, to prevent
*any* duplicate initialization (e.g. dlg positioning).

Fixed in cvs, thanks for reporting.

Regards,
Andreas

pgadmin-hackers by date:

Previous
From: cvs@cvs.pgadmin.org
Date:
Subject: CVS Commit by andreas: Fix new server ssl option duplication on connect
Next
From: Alexander Borkowski
Date:
Subject: Re: CVS Commit by dpage: Dynamically link libpq/OpenSSL