Thread: pgadmin3 font patch

Hi Dave.

I am sorry that confirmation is slow.

frmAbout,frmSplash
The character of the license-Information collapses.

Please apply this patch.

Regards,
Hiroshi-Saito

Hiroshi Saito wrote:

>Hi Dave.
>
>I am sorry that confirmation is slow.
>
>frmAbout,frmSplash
>The character of the license-Information collapses.
>
>Please apply this patch.
>
>
>
Hiroshi,

I'm not too happy about the font changing patches you posted, especially
the one that changed the font in ctlSQLBox back from fixed to normal.
Using a fixed font for SQL editing is a requirement.
Please find out which fixed font works for you, of if the usability of
wxMODERN can be determined at runtime.
If there's absolutely no other way, we'd need to have an option for this.

Regards,
Andreas

Hi Andreas.

From: "Andreas Pflug" <pgadmin@pse-consulting.de>
(snip)
> I'm not too happy about the font changing patches you posted, especially
> the one that changed the font in ctlSQLBox back from fixed to normal.
> Using a fixed font for SQL editing is a requirement.
> Please find out which fixed font works for you, of if the usability of
> wxMODERN can be determined at runtime.
> If there's absolutely no other way, we'd need to have an option for this.

Oh. I am sorry.
The original was hurt in such meaning.
How is it with this patch?
It was sufficient with my environment.

Regards,
Hiroshi-Saito

Hiroshi Saito wrote:

>Hi Andreas.
>
>From: "Andreas Pflug" <pgadmin@pse-consulting.de>
>(snip)
>
>
>>I'm not too happy about the font changing patches you posted, especially
>>the one that changed the font in ctlSQLBox back from fixed to normal.
>>Using a fixed font for SQL editing is a requirement.
>>Please find out which fixed font works for you, of if the usability of
>>wxMODERN can be determined at runtime.
>>If there's absolutely no other way, we'd need to have an option for this.
>>
>>
>
>Oh. I am sorry.
>The original was hurt in such meaning.
>How is it with this patch?
>It was sufficient with my environment.
>
>
>
Hi Hiroshi,
that fix doesn't work, because it only declares the default font to be
wxMODERN, but it actually won't act like that. It's still variable pitch.
What's going wrong if the previous implementation wxFont(9, wxMODERN,
wxNORMAL, wxNORMAL) is used?

Regards,
Andreas

Hi Andreas.

From: "Andreas Pflug" <pgadmin@pse-consulting.de>
> Hi Hiroshi,
> that fix doesn't work, because it only declares the default font to be
> wxMODERN, but it actually won't act like that. It's still variable pitch.
it was so...

> What's going wrong if the previous implementation wxFont(9, wxMODERN,
> wxNORMAL, wxNORMAL) is used?

It doesn't interpret multi-byte.
Hmm...

It is made the following as another method.
...
static wxLocale theLocaleObj(wxLANGUAGE_DEFAULT);
bool MyApp::OnInit() {
...
...

But, this brings about the same result again, too.
After all, even if it has optional establishment, the same conclusion again
will be reached.
Is there any good thought besides?

Regards,
Hiroshi-Saito

Hiroshi Saito wrote:

>Hi Andreas.
>
>From: "Andreas Pflug" <pgadmin@pse-consulting.de>
>
>
>>Hi Hiroshi,
>>that fix doesn't work, because it only declares the default font to be
>>wxMODERN, but it actually won't act like that. It's still variable pitch.
>>
>>
>it was so...
>
>
>
>>What's going wrong if the previous implementation wxFont(9, wxMODERN,
>>wxNORMAL, wxNORMAL) is used?
>>
>>
>
>It doesn't interpret multi-byte.
>Hmm...
>
>It is made the following as another method.
>...
>static wxLocale theLocaleObj(wxLANGUAGE_DEFAULT);
>bool MyApp::OnInit() {
>...
>...
>
>But, this brings about the same result again, too.
>After all, even if it has optional establishment, the same conclusion again
>will be reached.
>Is there any good thought besides?
>
>
>
So there's only one solution left: the font needs to be configurable.
I'll add this to frmOptions.

Regards,
Andreas

Hi Andreas.

From: "Andreas Pflug" <pgadmin@pse-consulting.de>
(snip)
> So there's only one solution left: the font needs to be configurable.
> I'll add this to frmOptions.

I agreed.
It is an ideal by a user's choosing it optionally.

Regards,
Hiroshi-Saito

Hiroshi Saito wrote:

>Hi Andreas.
>
>From: "Andreas Pflug" <pgadmin@pse-consulting.de>
>(snip)
>
>
>>So there's only one solution left: the font needs to be configurable.
>>I'll add this to frmOptions.
>>
>>
>
>I agreed.
>It is an ideal by a user's choosing it optionally.
>
>
>
Font is selectable now. Default is Courier New.9 for win32 and
monospace.12 for the rest. I think this will work for most users.

Regards,
Andreas