Re: BUG #1931: ILIKE and LIKE fails on Turkish locale - Mailing list pgsql-bugs

From Victor Snezhko
Subject Re: BUG #1931: ILIKE and LIKE fails on Turkish locale
Date
Msg-id uveo08ffc.fsf@indorsoft.ru
Whole thread Raw
In response to Re: BUG #1931: ILIKE and LIKE fails on Turkish locale  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BUG #1931: ILIKE and LIKE fails on Turkish locale
List pgsql-bugs
Tom Lane <tgl@sss.pgh.pa.us> writes:

>> Hmm, seems like plpgsql is also broken for multibyte encodings. it
>> contains some single-byte ops, like the following:
>
>>     while (*s && isspace((unsigned char) *s))
>>         s++;
>>     if (*s++ != '.')
>>         elog(ERROR, "expected dot between identifiers: %s", sstart);
>
> That code is not broken ... at least not unless isspace() is.

OK, sorry for the FUD, I'm just trying to find a cause... I will not
bring such ungrounded accusations next time.

But... maybe I misunderstand something fundamental, but should isspace
work when we pass one byte of multibyte character?

I'm digging this procedure (plpgsql_convert_ident()) and will report
if I find something wrong inside it and not inside isspace.

--
WBR, Victor V. Snezhko
E-mail: snezhko@indorsoft.ru

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #1931: ILIKE and LIKE fails on Turkish locale
Next
From: Tom Lane
Date:
Subject: Re: BUG #1931: ILIKE and LIKE fails on Turkish locale