Why not set builder->next_phase_at=InvalidTransactionId in SnapBuildRestore function? - Mailing list pgsql-general

From zxwsbg
Subject Why not set builder->next_phase_at=InvalidTransactionId in SnapBuildRestore function?
Date
Msg-id tencent_5C56966E364AD1F513D63684321DFAA0D207@qq.com
Whole thread Raw
Responses Re:Why not set builder->next_phase_at=InvalidTransactionId in SnapBuildRestore function?  ("zxwsbg" <zxwsbg@qq.com>)
List pgsql-general

Last email has some problem, I resend one.

In PG14 or higher version, I notice that SnapBuildRestore function don't set builder->next_phase_at=InvalidTransactionId .

But in SnapBuildSerialize function, the assert check this condition.

Assert(builder->next_phase_at == InvalidTransactionId);

I'd like to know is this right?

Thanks.

pgsql-general by date:

Previous
From: "zxwsbg"
Date:
Subject: Why not set builder->next_phase_at=InvalidTransactionId in SnapBuildRestore function?
Next
From: "zxwsbg"
Date:
Subject: Re:Why not set builder->next_phase_at=InvalidTransactionId in SnapBuildRestore function?