Re: [HACKERS] version functions (was NT port of PGSQL - success) - Mailing list pgsql-hackers

Jazzman wrote:
>
> Hello Bruce
>
> On Oct 8,  5:40pm, Bruce Momjian wrote:
> > I have removed the data/base/*/pg_version file because it was never
> > used.  We had removed the 'version' functions long ago, but
>                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Does this mean that the following from the FAQ is wrong?
>
>    3.25) How do I tell what PostgreSQL version I am running?
>
>    From psql, type select version();
>
> If so then this question should probably be changed to point users to the
> PG_VERSION file.

    No, it is still correct. The version function is there and it
    returns the compiled in string from version.h.

    But take a look at version.c please. I think  it  should  use
    memcpy()  or  strncpy()  instead of strcpy(). As it is now it
    writes the null byte after the palloc'ed area.


Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#======================================== jwieck@debis.com (Jan Wieck) #