Re: Fix pg_upgrade to preserve datdba - Mailing list pgsql-hackers

From Jan Wieck
Subject Re: Fix pg_upgrade to preserve datdba
Date
Msg-id ff77882d-1b1f-1735-402a-f4583f1b2f58@wi3ck.info
Whole thread Raw
In response to Re: Fix pg_upgrade to preserve datdba  (Jan Wieck <jan@wi3ck.info>)
Responses Re: Fix pg_upgrade to preserve datdba  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 3/21/21 1:15 PM, Jan Wieck wrote:
> On 3/21/21 12:57 PM, Tom Lane wrote:
>> Jan Wieck <jan@wi3ck.info> writes:
>>> On 3/20/21 12:39 AM, Jan Wieck wrote:
>>>> On the way pg_upgrade also mangles the pg_database.datdba
>>>> (all databases are owned by postgres after an upgrade; will submit a
>>>> separate patch for that as I consider that a bug by itself).
>> 
>>> Patch attached.
>> 
>> Hmm, doesn't this lose all *other* database-level properties?
>> 
>> I think maybe what we have here is a bug in pg_restore, its
>> --create switch ought to be trying to update the database's
>> ownership.
> 
> Possibly. I didn't look into that route.

Thanks for that. I like this patch a lot better.


Regards, Jan

-- 
Jan Wieck
Principle Database Engineer
Amazon Web Services

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: New IndexAM API controlling index vacuum strategies
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_upgrade failing for 200+ million Large Objects