Re: Avoid generating SSL certs for LDAP tests - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Avoid generating SSL certs for LDAP tests
Date
Msg-id ff407f18-ffa7-9dd8-bf5a-413bce775859@dunslane.net
Whole thread Raw
In response to Re: Avoid generating SSL certs for LDAP tests  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Avoid generating SSL certs for LDAP tests  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On 2022-12-19 Mo 10:25, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> We don't generate SSL certificates for running the SSL tests, but
>> instead use pregenerated certificates that are part of our source code.
>> This patch applies the same policy to the LDAP tests, and in fact simply
>> reuses certificates from the SSL test suite by copying them. It won't
>> save much but it should save a handful of cycles at run time.
> +1, but should there be a comment somewhere under test/ssl pointing
> out this external use of the certs?


OK, I'll find a place to mention that.


> Also, I bet this needs some adjustment for VPATH builds.            


I have tested it with both a make style vpath build and with meson - it
works fine.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Nikita Malakhov
Date:
Subject: Re: Patch: Global Unique Index
Next
From: Andrew Dunstan
Date:
Subject: Add a test to ldapbindpasswd