Re: TAP tests aren't using the magic words for Windows file access - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: TAP tests aren't using the magic words for Windows file access
Date
Msg-id fa256831-bbe6-667b-2253-6b0143d0d70a@2ndQuadrant.com
Whole thread Raw
In response to Re: TAP tests aren't using the magic words for Windows file access  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 11/4/19 10:41 PM, Michael Paquier wrote:
> On Sun, Nov 03, 2019 at 10:53:00PM -0500, Tom Lane wrote:
>> That is, TestLib::slurp_file is failing to read a file.  Almost
>> certainly, "permission denied" doesn't really mean a permissions
>> problem, but failure to specify the file-opening flags needed to
>> allow concurrent access on Windows.  We fixed this in pg_ctl
>> itself in commit 0ba06e0bf ... but we didn't fix the TAP
>> infrastructure.  Is there an easy way to get Perl on board
>> with that?
> If we were to use Win32API::File so as the file is opened in shared
> mode, we would do the same as what our frontend/backend code does (see
> $uShare):
> https://metacpan.org/pod/Win32API::File



Hmm. What would that look like? (My eyes glazed over a bit reading that
page - probably ENOTENOUGHCAFFEINE)


cheers


andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: segmentation fault when cassert enabled
Next
From: Tom Lane
Date:
Subject: Re: dropdb --force