Re: TAP tests aren't using the magic words for Windows file access - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: TAP tests aren't using the magic words for Windows file access
Date
Msg-id 20191105034138.GF16867@paquier.xyz
Whole thread Raw
In response to TAP tests aren't using the magic words for Windows file access  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: TAP tests aren't using the magic words for Windows file access
Re: TAP tests aren't using the magic words for Windows file access
List pgsql-hackers
On Sun, Nov 03, 2019 at 10:53:00PM -0500, Tom Lane wrote:
> That is, TestLib::slurp_file is failing to read a file.  Almost
> certainly, "permission denied" doesn't really mean a permissions
> problem, but failure to specify the file-opening flags needed to
> allow concurrent access on Windows.  We fixed this in pg_ctl
> itself in commit 0ba06e0bf ... but we didn't fix the TAP
> infrastructure.  Is there an easy way to get Perl on board
> with that?

If we were to use Win32API::File so as the file is opened in shared
mode, we would do the same as what our frontend/backend code does (see
$uShare):
https://metacpan.org/pod/Win32API::File
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Run-time pruning for ModifyTable
Next
From: Michael Paquier
Date:
Subject: Re: Logical replication wal sender timestamp bug