Hi Oleg,
On 1/22/18 4:37 PM, Stephen Frost wrote:
> Oleg,
>
> I'm not really sure why this is still in Needs Review as a review was
> posted and I don't see any follow-up. I've changed this to be Waiting
> for Author.
>
> * Antonin Houska (ah@cybertec.at) wrote:
>> Oleg Ivanov <o.ivanov@postgrespro.ru> wrote:
>>
>>> In order to overcome that issue, I would like to propose the patch, which
>>> provides possibility to use another approach of the WAL record
>>> construction.
>>
>> After having spent several hours reviewing this patch I dare to send the
>> following comments:
>
> Thanks for the review Antonin!
>
>> * writeToPtr() and readFromPtr() are applied to the existing code. I think
>> this is a reason for a separate diff, to be applied before the actual patch.
>
> I'm not really a fan of using these, for my 2c. I'm not sure how others
> feel, but having these macros which change one of the arguments to the
> macro (by advancing the pointer) doesn't result in a net improvement to
> readability for me.
>
> The other review comments also seem pretty reasonable to me.
This proposal is still in need of review and hasn't really gotten it in
the last few CFs.
Since the feature does not seem like a good fit for the last CF of PG11
I am marking it Returned with Feedback.
Regards,
--
-David
david@pgmasters.net
