Re: Tests for psql \g and \o - Mailing list pgsql-hackers

From Daniel Verite
Subject Re: Tests for psql \g and \o
Date
Msg-id f6a30254-d9cb-4e2a-9c77-21dcaf6c0100@manitou-mail.org
Whole thread Raw
In response to Re: Tests for psql \g and \o  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Tests for psql \g and \o
List pgsql-hackers
    Michael Paquier wrote:

> +psql_like($node, "SELECT 'one' \\g | cat >$g_file", qr//, "one command
> \\g");
> +my $c1 = slurp_file($g_file);
> +like($c1, qr/one/);
>
> Windows may not have an equivalent for "cat", no?  Note that psql's
> 001_basic.pl has no restriction in place for Windows.  Perhaps you
> could use the same trick as basebackup_to_shell, where GZIP is used to
> write some arbitrary data..  Anyway, this has some quoting issues
> especially if the file's path has whitespaces?  This is located in
> File::Temp::tempdir, still it does not sound like a good thing to rely
> on this assumption on portability grounds.

PFA a new patch addressing these issues.


Best regards,
--
Daniel Vérité
https://postgresql.verite.pro/
Twitter: @DanielVerite

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: Documentation for building with meson
Next
From: Robert Haas
Date:
Subject: Re: Add sub-transaction overflow status in pg_stat_activity