Re: Hot Standby 0.2.1 - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: Hot Standby 0.2.1
Date
Msg-id f67928030909180723q618ea60dvce7d9b1be269038c@mail.gmail.com
Whole thread Raw
In response to Hot Standby 0.2.1  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Hot Standby 0.2.1
List pgsql-hackers
On Tue, Sep 15, 2009 at 2:41 PM, Simon Riggs <simon@2ndquadrant.com> wrote:

OK, here is the latest version of the Hot Standby patchset. This is
about version 30+ by now, but we should regard this as 0.2.1
Patch against CVS HEAD (now): clean apply, compile, no known bugs.


Hi Simon,

Is there a reason that you remove the WAL_DEBUG shown below?


*************** begin:;
*** 899,923 ****
        FIN_CRC32(rdata_crc);
        record->xl_crc = rdata_crc;

- #ifdef WAL_DEBUG
-       if (XLOG_DEBUG)
-       {
-               StringInfoData buf;
-
-               initStringInfo(&buf);
-               appendStringInfo(&buf, "INSERT @ %X/%X: ",
-                                                RecPtr.xlogid, RecPtr.xrecoff);
-               xlog_outrec(&buf, record);
-               if (rdata->data != NULL)
-               {
-                       appendStringInfo(&buf, " - ");
-                       RmgrTable[record->xl_rmid].rm_desc(&buf, record->xl_info, rdata->data);
-               }
-               elog(LOG, "%s", buf.data);
-               pfree(buf.data);
-       }
- #endif
-
        /* Record begin of record in appropriate places */
        ProcLastRecPtr = RecPtr;
        Insert->PrevRecord = RecPtr;
--- 947,952 ----



Thanks,

Jeff

pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: Hot Standby 0.2.1
Next
From: Dimitri Fontaine
Date:
Subject: Re: happy birthday Tom Lane ...