Re: Hot Standby 0.2.1 - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Hot Standby 0.2.1
Date
Msg-id 1253284370.4155.29.camel@ebony.2ndQuadrant
Whole thread Raw
In response to Re: Hot Standby 0.2.1  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: Hot Standby 0.2.1
List pgsql-hackers
On Fri, 2009-09-18 at 07:23 -0700, Jeff Janes wrote:
> On Tue, Sep 15, 2009 at 2:41 PM, Simon Riggs <simon@2ndquadrant.com>
> wrote:
>         
>         OK, here is the latest version of the Hot Standby patchset.
>         This is
>         about version 30+ by now, but we should regard this as 0.2.1
>         Patch against CVS HEAD (now): clean apply, compile, no known
>         bugs.

> Is there a reason that you remove the WAL_DEBUG shown below?

WAL_DEBUG is not removed by the patch, though that section of code is
removed, as you observe. I recall an earlier bug report by
me/conversation on hackers about how that section of code was
irrecoverably broken, since it's calling an rmgr routine while not in
recovery and also assuming the data is fully accessible at that point,
which it is not.

-- Simon Riggs           www.2ndQuadrant.com



pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: happy birthday Tom Lane ...
Next
From: Selena Deckelmann
Date:
Subject: Re: happy birthday Tom Lane ...