Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Date
Msg-id f3d69b00-f922-4d2b-bf6d-1b87cc221cb3@eisentraut.org
Whole thread Raw
In response to Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Tree view 
On 13.05.24 12:22, Aleksander Alekseev wrote:
> Hi,
> 
>>> Thanks. I see a few pieces of code that use special FOO_NUMBER enum
>>> values instead of a macro. Should we refactor these pieces
>>> accordingly? PFA another patch.
>>
>> I think this is a sensible improvement.
>>
>> But please keep the trailing commas on the last enum items.
> 
> Thanks, fixed.

committed

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Row pattern recognition
Next
From: Aleksey Demakov
Date:
Subject: coupling of index and table access methods