Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Date
Msg-id CAJ7c6TNhRz7o=1LcwpQOb6v_8-Kz7TXKdty2-=bT=VaVevi7PQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
Tree view 
Hi,

> > Thanks. I see a few pieces of code that use special FOO_NUMBER enum
> > values instead of a macro. Should we refactor these pieces
> > accordingly? PFA another patch.
>
> I think this is a sensible improvement.
>
> But please keep the trailing commas on the last enum items.

Thanks, fixed.

-- 
Best regards,
Aleksander Alekseev
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: SQL:2011 application time
Next
From: Alexander Korotkov
Date:
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands