Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Date
Msg-id e9f02a1d-a1e0-45d2-9572-4a16b4d658d4@eisentraut.org
Whole thread Raw
In response to Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS  (Aleksander Alekseev <aleksander@timescale.com>)
Responses Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
List pgsql-hackers
Tree view 
On 19.04.24 11:47, Aleksander Alekseev wrote:
> Thanks. I see a few pieces of code that use special FOO_NUMBER enum
> values instead of a macro. Should we refactor these pieces
> accordingly? PFA another patch.

I think this is a sensible improvement.

But please keep the trailing commas on the last enum items.

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs
Next
From: Peter Eisentraut
Date:
Subject: Re: Logging which interface was connected to in log_line_prefix