On 2018/03/23 2:51, Robert Haas wrote:
> On Wed, Jan 17, 2018 at 1:03 AM, Amit Langote <amitlangote09@gmail.com> wrote:
>> On Wed, Jan 17, 2018 at 1:51 PM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>>> On Tue, Jan 16, 2018 at 11:38:58PM -0500, Tom Lane wrote:
>>>> Yeah, pg_upgrade already has to cope with cases where the newer version
>>>> thinks a table needs a toast table when the older version didn't, or
>>>> vice versa. This looks like it ought to fall into that category.
>>>> Not that testing it wouldn't be a good idea.
>>>
>>> As far as I can see this statement is true. If you create a parent
>>> partition table in a v10 cluster, and then upgrade to HEAD with this
>>> patch applied, you'll be able to notice that the relation still has its
>>> toast table present, while newly-created parent partitions would have
>>> nothing. (Just tested, I didn't review the patch in details).
>>
>> Thanks for checking. I too checked that pg_upgrading v10 cluster
>> containing partitioned tables that have a TOAST table attached to it
>> works normally and like Michael says, the TOAST table remains.
>
> I have committed your patch.
Thank you!
Regards,
Amit
