Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns
Date
Msg-id f242cb2a-66d2-1ac2-d76e-1638ec9cc26d@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns  (Matheus Alcantara <mths.dev@pm.me>)
List pgsql-hackers
Tree view 
On 26.10.22 00:45, Matheus Alcantara wrote:
>> I noticed that psql has no tab completion around identity columns in
>> ALTER TABLE, so here's some patches for that.
>>
>> In passing, I also added completion for ALTER SEQUECNE … START, which was
>> missing for some reason.

> I've tested all 4 of your patches, and all of them seem to work as expected.
> 
> This is my first time reviewing a patch, so let's see if more experience
> hackers has anything more to say about these patches, but at first they
> seem correct to me.

This was sensible for a first review.  Thanks for you help.

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns
Next
From: David Rowley
Date:
Subject: Add palloc_aligned() to allow arbitrary power of 2 memory alignment