Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns - Mailing list pgsql-hackers

From Matheus Alcantara
Subject Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns
Date
Msg-id O6GB3SIM-aNw1FgXVh0AcY-5sOsKOQrbDiBoXZxfYqP0uSQTfr87xf1nd6Lp9fWMad_1P7g0GQu-UqM_106PMpR_VsVFXGKi2CNmVzxZTXg=@pm.me
Whole thread Raw
In response to [PATCH] Improve tab completion for ALTER TABLE on identity columns  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: [PATCH] Improve tab completion for ALTER TABLE on identity columns  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
Tree view 
> Hi Hackers,
>
> I noticed that psql has no tab completion around identity columns in
> ALTER TABLE, so here's some patches for that.
>
> In passing, I also added completion for ALTER SEQUECNE … START, which was
> missing for some reason.
>
> - ilmari

Hi ilmari

I've tested all 4 of your patches, and all of them seem to work as expected.

This is my first time reviewing a patch, so let's see if more experience
hackers has anything more to say about these patches, but at first they
seem correct to me.


--
Matheus Alcantara

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Reducing duplicativeness of EquivalenceClass-derived clauses
Next
From: Jacob Champion
Date:
Subject: Re: [PATCH] CF app: add "Returned: Needs more interest"