Re: More test/kerberos tweaks - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: More test/kerberos tweaks
Date
Msg-id f1fd9ccaf7ffb2327bf3c06120afeadd50c1db97.camel@vmware.com
Whole thread Raw
In response to Re: More test/kerberos tweaks  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, 2021-02-05 at 15:55 -0500, Tom Lane wrote:
> We have, almost invariably, regretted it when we tried to use short
> timeouts in test cases.

That's what I was afraid of. I can work around it easily enough on my
local machine, so it's not really a blocker in any sense.

That just leaves the first patch, then.

> On the whole, I think the right thing to be doing here is not so
> much messing with the timeout as fixing the test script to be
> more robust against control-C.  If it's failing to shut down the
> KDC, I'd say that's a test bug.

Agreed. I'm trying to limit the amount of test churn I introduce, since
I don't speak Perl very well. :D

Reworking the log checks so that they didn't need timeouts (e.g. by
stopping the server or otherwise flushing the logs, a la the
ssl_passphrase_callback tests) would be another approach. I'll jot it
down to look into later.

--Jacob

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: making update/delete of inheritance trees scale better
Next
From: Stephen Frost
Date:
Subject: Re: Key management with tests