Re: Unexpected behavior when setting "idle_replication_slot_timeout" - Mailing list pgsql-bugs

From Laurenz Albe
Subject Re: Unexpected behavior when setting "idle_replication_slot_timeout"
Date
Msg-id f12271e6aea3b87eaa430d0c9008ca1f3154c31e.camel@cybertec.at
Whole thread Raw
In response to Re: Unexpected behavior when setting "idle_replication_slot_timeout"  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Unexpected behavior when setting "idle_replication_slot_timeout"
List pgsql-bugs
On Sat, 2025-07-05 at 12:13 -0400, Tom Lane wrote:
> Oh, wait a second.  I just noticed that this variable is new in v18.
> So there won't be a compatibility issue as long as we change it in
> v18 too.  So changing it to a base of seconds seems sufficient,
> and more in line with existing practice:
>
> Using 'ms' seems clearly overkill, but there's precedent for
> timeouts measured in seconds.

Here is a patch that changes the unit to seconds, like Fujii Masao's
patch upthread.  In addition, it removes the now unnecessary injection
point for the TAP test and tries to improve the documentation to
address my complaints.

Yours,
Laurenz Albe

Attachment

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #18981: Fault tolerance and improvement for xmltotext_with_options (xml.c)
Next
From: Jeff Davis
Date:
Subject: Re: BUG #18965: Issue with Short-Circuit Evaluation in Boolean Expressions