Re: BUG #18981: Fault tolerance and improvement for xmltotext_with_options (xml.c) - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #18981: Fault tolerance and improvement for xmltotext_with_options (xml.c)
Date
Msg-id 882827.1751993516@sss.pgh.pa.us
Whole thread Raw
In response to BUG #18981: Fault tolerance and improvement for xmltotext_with_options (xml.c)  (PG Bug reporting form <noreply@postgresql.org>)
List pgsql-bugs
PG Bug reporting form <noreply@postgresql.org> writes:
> Please look at this code:
> https://github.com/postgres/postgres/blob/a27893df45ec5d8c657899202e9cf0b9a816fe2f/src/backend/utils/adt/xml.c#L730
> xmlerrcxt = pg_xml_init(PG_XML_STRICTNESS_ALL);
> pg_xml_init uses palloc and may "raise an exception".

Yup, we should cover that case.

> Also
> Within PG_CATCH 'doc' is not NULL.

Agreed.  Pushed your fix with small editorialization.

            regards, tom lane



pgsql-bugs by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"
Next
From: Laurenz Albe
Date:
Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"